[Kde-pim] Review Request 112976: Map QString to text instead of Bytea with PostgreSQL backend

[Cédric Villemain]

> On Sept. 28, 2013, 12:35 p.m., Dan Vrátil wrote:
> > server/src/storage/dbinitializer_p.cpp, line 283
> > <http://git.reviewboard.kde.org/r/112976/diff/1/?file=192933#file192933line283>
> >
> >     Could you elaborate the FIXME a bit more? :-)
> >     
> >     I remember you said we could/should use QSqlDriver::formatValue() so maybe you could resolve the FIXME right away and replace the code with it.setValue(driver.formatValue(....)) :-)

The FIXME is an hersazt of my code edition grabbed by git/reviewoard.
Tks for the example of usage.


> On Sept. 28, 2013, 12:35 p.m., Dan Vrátil wrote:
> > server/src/storage/dbupdate.xml, line 173
> > <http://git.reviewboard.kde.org/r/112976/diff/1/?file=192934#file192934line173>
> >
> >     How long does the conversion take on a reasonable-sized database? If it's over a minute, we need to tell clients we are upgrading the database so that they know why their Akonadi does not work :-)
> >     
> >     Reporting of upgrading is currently broken in master. The fix is in parttable-optimization branch though, so we should either merge it (I'm not sure I want to do it yet), or at least cherry-pick the commit, if it's possible (I'll have to check, I did quite some changes to the upgrade mechanism)

conversion will rewrite the tables. So it takes the time to read/write that (and have some IO sync when committing transaction). I don't expect that to go over a minute in most cases as tables are not really large (some tens or hundred of MB IIRC)

I keep the 'false' state on error as all the previous dbupdate. But it should stop and retry the SQL transaction on faillure...


> On Sept. 28, 2013, 12:35 p.m., Dan Vrátil wrote:
> > server/src/storage/dbupdate.xml, line 174
> > <http://git.reviewboard.kde.org/r/112976/diff/1/?file=192934#file192934line174>
> >
> >     This is just a rant, but could you keep the CamelCase convention for table and column names, as used above?

sure


- Cédric


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112976/#review40949
-----------------------------------------------------------


On Sept. 28, 2013, 11:16 a.m., Cédric  Villemain wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112976/
> -----------------------------------------------------------
> 
> (Updated Sept. 28, 2013, 11:16 a.m.)
> 
> 
> Review request for Akonadi.
> 
> 
> Description
> -------
> 
> It's what suggested by QTSql.
> 
> It also happens to fix the recent issues raising around '\\SEEN' errors in SQL queries. It was visible because QTSql somewhat improve the postgresql driver, and so... akonadi revealed its own bug.
> 
> 
> Diffs
> -----
> 
>   server/src/storage/dbinitializer_p.cpp 55afaa9884df5cc1c3513907cbc3ac23785b0136 
>   server/src/storage/dbupdate.xml 2b1955e3e156b6dbe1a95759be1a6bbedd7c9732 
> 
> Diff: http://git.reviewboard.kde.org/r/112976/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Cédric  Villemain
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/