[Kde-pim] Review Request 112774: Support SILENT parameter in STORE command

[Christian Mollekopf]

> On Sept. 18, 2013, 1:12 p.m., Christian Mollekopf wrote:
> > > I'm not 100% whether we can actually do it this way - there's a risk that clients could overwrite the change (?), but I don't see any other way how to do it right now :)
> > 
> > I don't think there is any way around that if you want to avoid the notifications altogether. For the case of GID migration I don't think that this is a problem as one has to explicitly update the GID (so it's unlikely to be owerwritten, and if it is we don't care). The second issue are outdated caches that are again unlikely to be a problem in case of GID.
> > Do you have other usecases in mind that could help identify some problems (I can't)?
> 
> Dan Vrátil wrote:
>     GID is a specific case, but one can silently change anything - including RID, flags, payload, etc - that would already be a problem (you silently change RID of an event, then you edit the event in KOrganizer and it will overwrite it with the "old" RID) 
>     
>      Maybe we should be more strict and allow only silent GID change - after all, that's the only reason and usecase at this moment.

Yeah, I think it's save for invariants (for which RID might qualify as well), but could otherwise easily lead to problems.
However, I'm not sure we require this feature at all. Can't resources simply ignore GID changes? After all that's what we have the changeflags for, no?

To avoid issuing the change notifications I guess clients should need to register for a certain set of changes. That's a bigger change, but maybe we can live with the superfluous signals meanwhile, instead of extending the protocol for such a special usecase?


- Christian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112774/#review40264
-----------------------------------------------------------


On Sept. 17, 2013, 12:55 p.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112774/
> -----------------------------------------------------------
> 
> (Updated Sept. 17, 2013, 12:55 p.m.)
> 
> 
> Review request for Akonadi and Volker Krause.
> 
> 
> Description
> -------
> 
> Server counterpart to https://git.reviewboard.kde.org/r/112773/
> 
> I'm not 100% whether we can actually do it this way - there's a risk that clients could overwrite the change (?), but I don't see any other way how to do it right now :)
> 
> 
> Diffs
> -----
> 
>   server/src/handler/store.h a9a31b7 
>   server/src/handler/store.cpp b87cfe3 
>   server/src/storage/datastore.h 85a46b4 
>   server/src/storage/datastore.cpp 708e2b3 
> 
> Diff: http://git.reviewboard.kde.org/r/112774/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/