[Kde-pim] Review Request 112774: Support SILENT parameter in STORE command

Volker Krause vkrause at kde.org
Wed Sep 18 15:35:35 BST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112774/#review40269
-----------------------------------------------------------


Looks rather dangerous indeed. Conflict detection would detect most cases of applications overwriting the outdated fields again, but that usually results in errors that are hard to deal with for users. Wrongly used this would also cause resources to miss changes that should be synced to their backend (this is public API for everyone after all).

- Volker Krause


On Sept. 17, 2013, 12:55 p.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112774/
> -----------------------------------------------------------
> 
> (Updated Sept. 17, 2013, 12:55 p.m.)
> 
> 
> Review request for Akonadi and Volker Krause.
> 
> 
> Description
> -------
> 
> Server counterpart to https://git.reviewboard.kde.org/r/112773/
> 
> I'm not 100% whether we can actually do it this way - there's a risk that clients could overwrite the change (?), but I don't see any other way how to do it right now :)
> 
> 
> Diffs
> -----
> 
>   server/src/handler/store.h a9a31b7 
>   server/src/handler/store.cpp b87cfe3 
>   server/src/storage/datastore.h 85a46b4 
>   server/src/storage/datastore.cpp 708e2b3 
> 
> Diff: http://git.reviewboard.kde.org/r/112774/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list