[Kde-pim] Review Request 112592: Save/Restore size of Contact VIewer Dialog

[Allen Winter]

> On Sept. 8, 2013, 7:54 p.m., Dan Vrátil wrote:
> > akonadi/contact/contactviewerdialog.cpp, line 46
> > <http://git.reviewboard.kde.org/r/112592/diff/1/?file=188248#file188248line46>
> >
> >     You can initialize the second argument to QSize(500, 600) so you can omit the "if" branch below since size will always be valid.

except i've seen config files that people screwup by-hand.  so I try not to rely on valid readconfig returns.


> On Sept. 8, 2013, 7:54 p.m., Dan Vrátil wrote:
> > akonadi/contact/contactviewerdialog.cpp, line 59
> > <http://git.reviewboard.kde.org/r/112592/diff/1/?file=188248#file188248line59>
> >
> >     sync() is called from KConfig destructor, so no need to call it explicitely

good point.
old habit.


- Allen


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112592/#review39595
-----------------------------------------------------------


On Sept. 8, 2013, 4:54 p.m., Allen Winter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112592/
> -----------------------------------------------------------
> 
> (Updated Sept. 8, 2013, 4:54 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> Save/Restore the size of the Contact Viewer Dialog.
> 
> I think this can go into 4.11 as well since I'm not changing the public interface, but I'd like someone to verify that for me.
> 
> 
> Diffs
> -----
> 
>   akonadi/contact/contactviewerdialog.cpp eac2250 
> 
> Diff: http://git.reviewboard.kde.org/r/112592/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Allen Winter
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/