[Kde-pim] Review Request 112592: Save/Restore size of Contact VIewer Dialog

[Dan Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112592/#review39595
-----------------------------------------------------------



akonadi/contact/contactviewerdialog.cpp
<http://git.reviewboard.kde.org/r/112592/#comment29175>

    You can initialize the second argument to QSize(500, 600) so you can omit the "if" branch below since size will always be valid.



akonadi/contact/contactviewerdialog.cpp
<http://git.reviewboard.kde.org/r/112592/#comment29174>

    sync() is called from KConfig destructor, so no need to call it explicitely


- Dan Vrátil


On Sept. 8, 2013, 6:54 p.m., Allen Winter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112592/
> -----------------------------------------------------------
> 
> (Updated Sept. 8, 2013, 6:54 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> Save/Restore the size of the Contact Viewer Dialog.
> 
> I think this can go into 4.11 as well since I'm not changing the public interface, but I'd like someone to verify that for me.
> 
> 
> Diffs
> -----
> 
>   akonadi/contact/contactviewerdialog.cpp eac2250 
> 
> Diff: http://git.reviewboard.kde.org/r/112592/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Allen Winter
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/