[Kde-pim] Review Request 112793: Add tab for adding/removing Akonadi agents to KAdressbook settings dialog

[Kevin Krammer]

> On Sept. 18, 2013, 3:06 p.m., Kevin Krammer wrote:
> > Doesn't KAddressBook already have add/remove addressbook in its main UI?
> > Nicely hiding the fact that they are Akonadi resources?
> 
> Dan Vrátil wrote:
>     File->New->Add Address Book
>     
>     I know about the option, but it's completely inconsistent with all other PIM apps (which is especially visible when using Kontact)
> 
> Kevin Krammer wrote:
>     If I look at the pre-Akonadi version, only KMail had an account config. all others add/remove their sources inline.
>     If we want to have generic "add $type" KCMs then those should probably go to kdepim-runtime or kdepimlibs
>     Didn't we have a generic resource managment KCM already?
> 
> Dan Vrátil wrote:
>     There is indeed a KCM for generic resource managemen, but the problem is in "generic" - you don't want to see IMAP resources in KAdressbook configurationc :). AFAIK KCModules are not very transparent to clients, so I don't know whether it is possible for client to manually apply mime-type filter after the module is loaded?
>     
>     One thing I could do is to make a widget in kdepimlibs that would have the search field, the Add/Modify/Remove (maybe Restart) buttons and the agents view and a simple API for clients to just set the mimetype filter - looking in KDE PIM, atm all clients assemble the widget themselves, each slightly differently :)
>     
>

I think the MIME filter can be specified at KCM loading time. I am pretty sure I used that somewhere.
Ah, right: kdepim-runtime/kresource/shared/resourceconfigbase.cpp
Using the same KCM for addressbook and calendar resource configuration


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112793/#review40275
-----------------------------------------------------------


On Sept. 18, 2013, 3:02 p.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112793/
> -----------------------------------------------------------
> 
> (Updated Sept. 18, 2013, 3:02 p.m.)
> 
> 
> Review request for KDEPIM and Tobias Koenig.
> 
> 
> Description
> -------
> 
> A tab for adding Akonadi resources is in KMail, KOrganizer, Akregator and other Akonadi apps, so users would expect the same tab to be available in KAdressbook - this patch creates a new KCM module that adds "General" tab to KAddressbook with UI for adding, configuring and removing agents, like in the other mentioned apps.
> 
> 
> Diffs
> -----
> 
>   kaddressbook/CMakeLists.txt 3756e60 
>   kaddressbook/config/CMakeLists.txt PRE-CREATION 
>   kaddressbook/config/config_general.h PRE-CREATION 
>   kaddressbook/config/config_general.cpp PRE-CREATION 
>   kaddressbook/config/config_general.ui PRE-CREATION 
>   kaddressbook/config/kaddressbook_config_general.desktop PRE-CREATION 
>   kaddressbook/mainwidget.cpp 6141b39 
> 
> Diff: http://git.reviewboard.kde.org/r/112793/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/