[Kde-pim] Review Request 112794: Don't notify clients about GID-only changes

[Dan Vrátil]

> On Sept. 18, 2013, 5:35 p.m., Christian Mollekopf wrote:
> > It's not really what I meant but I guess that works too ;-)
> > 
> > It could be a bit magic behaviour to skip notifications in that special case (it's not what you would normally expect, is it?), that's why I suggested that resources should rather just ignore GID changes than the notifications not being emitted, but if you feel confident about it I'm fine with it.

When something else is changed together with the GID, the notification /will/ be emitted - so that's not a problem and the "magical" case can be documented.

Ignoring changes on client side is bit more difficult, we would have to list "GID" in the list of changed item parts and then filter out such notifications on the client side, so it would be as "magic" that they are not delivered as it is that we don't emit them at all :-)

The second benefit of this is server-side filtering is that once you write GID migration plugin for emails, migrating thousands of emails won't overload KMail and especially the resources with thousands of notifications about the change. Migrating few hundreds contacts is nothing...but hundreds of thousands of emails won't be that fun - that's why I would like to stop the emission already on the server instead of client side.


- Dan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112794/#review40279
-----------------------------------------------------------


On Sept. 18, 2013, 5:19 p.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112794/
> -----------------------------------------------------------
> 
> (Updated Sept. 18, 2013, 5:19 p.m.)
> 
> 
> Review request for Akonadi.
> 
> 
> Description
> -------
> 
> Store GID in database, but don't send out notification.
> 
> This obsoletes both STORE SILENT reviews :)
> 
> 
> Diffs
> -----
> 
>   server/src/handler/store.cpp b87cfe3 
> 
> Diff: http://git.reviewboard.kde.org/r/112794/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/