[Kde-pim] Review Request 112786: Close IMAP mailbox before deleting it

[Dan Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112786/
-----------------------------------------------------------

(Updated Sept. 24, 2013, 7:16 p.m.)


Review request for KDEPIM and Kevin Ottens.


Changes
-------

Updated unit-tests for RemoveCollectionRecursiveTask. RemoveCollectionTask assumes that a mailbox is selected on a session, but it does not seem to be possible to change state of session of FakeServer from the unit-test.


Description
-------

Some IMAP servers don't allow deleting a currently SELECTed mailbox, so we close it before DELETEing it (see the referenced bug).

I haven't found any such restriction in RFC, but we all know that reality does not always follow RFCs :-)


This addresses bug 324932.
    http://bugs.kde.org/show_bug.cgi?id=324932


Diffs (updated)
-----

  resources/imap/removecollectionrecursivetask.cpp aa74a73 
  resources/imap/removecollectiontask.h 48335d3 
  resources/imap/removecollectiontask.cpp b258fb1 
  resources/imap/resourcestateinterface.cpp 4784668 
  resources/imap/tests/testremovecollectiontask.cpp 56bcaab 

Diff: http://git.reviewboard.kde.org/r/112786/diff/


Testing
-------


Thanks,

Dan Vrátil

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/