[Kde-pim] Review Request 112786: Close IMAP mailbox before deleting it
Sandro Knauß
mail at sandroknauss.de
Fri Sep 27 23:48:23 BST 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112786/#review40927
-----------------------------------------------------------
resources/imap/removecollectionrecursivetask.cpp
<http://git.reviewboard.kde.org/r/112786/#comment30066>
If i understood it right: first the mailbox has to be closed (via CloseJob) and afterwards it can be deleted (via DeleJob).
For the removecollectiontask I see this chainging of jobs (line 50-59 in .cpp). But for removecollectionrecursivetask you start closeJob and deleteJob the same time.
- Sandro Knauß
On Sept. 24, 2013, 5:16 p.m., Dan Vrátil wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112786/
> -----------------------------------------------------------
>
> (Updated Sept. 24, 2013, 5:16 p.m.)
>
>
> Review request for KDEPIM and Kevin Ottens.
>
>
> Description
> -------
>
> Some IMAP servers don't allow deleting a currently SELECTed mailbox, so we close it before DELETEing it (see the referenced bug).
>
> I haven't found any such restriction in RFC, but we all know that reality does not always follow RFCs :-)
>
>
> This addresses bug 324932.
> http://bugs.kde.org/show_bug.cgi?id=324932
>
>
> Diffs
> -----
>
> resources/imap/removecollectionrecursivetask.cpp aa74a73
> resources/imap/removecollectiontask.h 48335d3
> resources/imap/removecollectiontask.cpp b258fb1
> resources/imap/resourcestateinterface.cpp 4784668
> resources/imap/tests/testremovecollectiontask.cpp 56bcaab
>
> Diff: http://git.reviewboard.kde.org/r/112786/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dan Vrátil
>
>
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
More information about the kde-pim
mailing list