[Kde-pim] Review Request 112958: Increase reference count of favourite collections

[Dan Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112958/
-----------------------------------------------------------

(Updated Nov. 21, 2013, 3:49 p.m.)


Status
------

This change has been discarded.


Review request for KDEPIM-Libraries.


Repository: kdepimlibs


Description
-------

Increase refcnt of each collection added to Favourites, and decrease it when it's removed.
    
This fixes an endless fetch-purge loop when user added more than 10 favourite collections (which is a limit for Akonadi::MonitorPrivate::Buffer), which was triggered by the model trying to fit more than 10 collections into 10-sized buffer.


I don't know whether this is the proper way to fix this problem, but it works and does not seem to have any sideeffects.


Diffs
-----

  akonadi/favoritecollectionsmodel.cpp 884a206088edad5d2699dd8570e3822323e89a27 

Diff: http://git.reviewboard.kde.org/r/112958/diff/


Testing
-------

Successfully added more than 10 collections to favourites without triggering the problem


Thanks,

Dan Vrátil

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/