[Kde-pim] Review Request 113855: Make compile on MSVC2010

Kevin Funk krf at gmx.de
Mon Nov 18 09:47:15 GMT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113855/
-----------------------------------------------------------

(Updated Nov. 18, 2013, 9:47 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDEPIM-Libraries and Patrick Spendrin.


Repository: kdepimlibs


Description
-------

Make compile on MSVC2010

Multiple fixes:
* Use remove_definitions to remove compiler flags, -U via CXX_FLAGS
  doesn't seem to work for MSVC. Please check if would make sense for
  the other occurences in akonadi/*/CMakeLists.txt as well
* Fix an error/typo(?) in entitiycache_p.h. Use template parameter
  instead of 'Item' class. Please check if this is correct
* Include ktcpsocket.h for KSslErrorUiData class


Diffs
-----

  akonadi/calendar/CMakeLists.txt 5bdb2534ec0428b66a55206cd21a75efbf817cc2 
  akonadi/entitycache_p.h e08ee3a9b79a2704a58ebd5086b28843841ec2b6 
  akonadi/notes/CMakeLists.txt 834328d62ca0c12b42d8cdddf533311e7711dfe3 
  kimap/tests/testimapidle.cpp 1f443af54d872a90ec89cd011c616192683a4b9c 

Diff: http://git.reviewboard.kde.org/r/113855/diff/


Testing
-------


Thanks,

Kevin Funk

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list