[Kde-pim] Review Request 113855: Make compile on MSVC2010

[Kevin Funk]

> On Nov. 14, 2013, 1:08 p.m., Patrick Spendrin wrote:
> > akonadi/notes/CMakeLists.txt, line 7
> > <http://git.reviewboard.kde.org/r/113855/diff/1/?file=214047#file214047line7>
> >
> >     removing might not help on Windows at runtime because those casts must not be available at runtime in the dll interface (no exported functions for these casts).
> 
> Kevin Funk wrote:
>     Hm? I'm removing it because remove_definitions already takes care of undefining the QT_NO_FOOBAR flags. Hence, if we leave the -UQT_NO_FOOBAR parameters in CXX_FLAGS it's basically a no-op, no?
> 
> Patrick Spendrin wrote:
>     No, the problem might be different: if QtCore is compiled with QT_NO_CAST_TO_ASCII set, some casting overloads are missing in the QtCore dll. remove_definitions won't bring them back, but might only lead to a linker error (but I guess you didn't have that? - my concern might be invalid in that case.)

I think it doesn't matter if QtCore is compiled with or w/o QT_NO_CAST_TO_ASCII/QT_NO_CAST_FROM_ASCII. These functions are inline anyway, that means they're always available in client code. That means, compiling QtCore with or w/o QT_NO_CAST_TO_ASCII/QT_NO_CAST_FROM_ASCII doesn't affect the resulting library. At least, I think so...

Anyway, don't make up such horrible scenarios, Patrick. :)


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113855/#review43660
-----------------------------------------------------------


On Nov. 14, 2013, 12:36 p.m., Kevin Funk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113855/
> -----------------------------------------------------------
> 
> (Updated Nov. 14, 2013, 12:36 p.m.)
> 
> 
> Review request for KDEPIM-Libraries and Patrick Spendrin.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> Make compile on MSVC2010
> 
> Multiple fixes:
> * Use remove_definitions to remove compiler flags, -U via CXX_FLAGS
>   doesn't seem to work for MSVC. Please check if would make sense for
>   the other occurences in akonadi/*/CMakeLists.txt as well
> * Fix an error/typo(?) in entitiycache_p.h. Use template parameter
>   instead of 'Item' class. Please check if this is correct
> * Include ktcpsocket.h for KSslErrorUiData class
> 
> 
> Diffs
> -----
> 
>   akonadi/calendar/CMakeLists.txt 5bdb2534ec0428b66a55206cd21a75efbf817cc2 
>   akonadi/entitycache_p.h e08ee3a9b79a2704a58ebd5086b28843841ec2b6 
>   akonadi/notes/CMakeLists.txt 834328d62ca0c12b42d8cdddf533311e7711dfe3 
>   kimap/tests/testimapidle.cpp 1f443af54d872a90ec89cd011c616192683a4b9c 
> 
> Diff: http://git.reviewboard.kde.org/r/113855/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin Funk
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/