[Kde-pim] Review Request 112958: Increase reference count of favourite collections

[Christian Mollekopf]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112958/#review44102
-----------------------------------------------------------


While this patch does prevent items from getting purged if referenced in the favorite model, the buffering still gets broken if no favorites are used.
I'm therefore not in favor of adding this patch as it only works around half the problem. Either we fix the root cause (too many rootIndexAboutToBeRemoved/added) signals, or we add a workaround that fixes all problems (likely disconnecting from rootIndexAboutToBeRemoved, or compressing the events).

- Christian Mollekopf


On Sept. 26, 2013, 11:51 a.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112958/
> -----------------------------------------------------------
> 
> (Updated Sept. 26, 2013, 11:51 a.m.)
> 
> 
> Review request for KDEPIM-Libraries.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> Increase refcnt of each collection added to Favourites, and decrease it when it's removed.
>     
> This fixes an endless fetch-purge loop when user added more than 10 favourite collections (which is a limit for Akonadi::MonitorPrivate::Buffer), which was triggered by the model trying to fit more than 10 collections into 10-sized buffer.
> 
> 
> I don't know whether this is the proper way to fix this problem, but it works and does not seem to have any sideeffects.
> 
> 
> Diffs
> -----
> 
>   akonadi/favoritecollectionsmodel.cpp 884a206088edad5d2699dd8570e3822323e89a27 
> 
> Diff: http://git.reviewboard.kde.org/r/112958/diff/
> 
> 
> Testing
> -------
> 
> Successfully added more than 10 collections to favourites without triggering the problem
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/