[Kde-pim] Review Request 113992: Only emit the dataChanged signal for fetched collections.

[Christian Mollekopf]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113992/
-----------------------------------------------------------

(Updated Nov. 21, 2013, 9:54 a.m.)


Review request for KDEPIM, Dan Vrátil, Stephen Kelly, and Volker Krause.


Bugs: 327865
    http://bugs.kde.org/show_bug.cgi?id=327865


Repository: kdepimlibs


Description
-------

Only emit the dataChanged signal for fetched collections.

For item fetches the collection hasn't changed and row inserted notifications are
used to signal new rows. This fixes and endless fetch loop caused by the
proxy models on top accidentally purging the fetched items after getting
a dataChanged signal, resulting in the items being fetched again, resulting in
a data changed signal, etc.
While this doesn't fix the incorrect behaviour of the proxy models, it still
fixes the incorrect behaviour of the ETM, and resolves the endless loop at least.


Diffs
-----

  akonadi/entitytreemodel_p.cpp 26eef9cd8494206784df4dea5d61649eb1fae0bd 

Diff: http://git.reviewboard.kde.org/r/113992/diff/


Testing
-------

works for me with kmail, unittests will follow.


Thanks,

Christian Mollekopf

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/