[Kde-pim] Review Request 109575: Reply to decrypted mail quotes encrypted text

Commit Hook null at kde.org
Sat Mar 30 17:54:47 GMT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109575/#review30159
-----------------------------------------------------------


This review has been submitted with commit ad92ce480599b7f36586174883f7bc6bb7e0f5ca by Sandro Knauß to branch KDE/4.10.

- Commit Hook


On March 19, 2013, 3:05 a.m., Sandro Knauß wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109575/
> -----------------------------------------------------------
> 
> (Updated March 19, 2013, 3:05 a.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> Replying messages with have the decrypted test in body and not the encrypted message.
> 
> The problem is that objectTreeParser actually disables very much functionality, if there is no htmlWriter available. 
> So inline Encrypted Messages won't be decoded because there is a if ( !htmWriter() ) return False in writeBodyString.
> 
> The new process structer is to use if ( htmWriter() ) for those parts that actualley creating html output.
> 
> 
> This addresses bug 298911.
>     http://bugs.kde.org/show_bug.cgi?id=298911
> 
> 
> Diffs
> -----
> 
>   messageviewer/objecttreeparser.cpp bb951d7486dad2941409bffd930797026785b706 
> 
> Diff: http://git.reviewboard.kde.org/r/109575/diff/
> 
> 
> Testing
> -------
> 
> tests available in messagecomposer, messageviewer and templateparser ( see also #109578 for the additional inline test for templateparser).
> 
> 
> Thanks,
> 
> Sandro Knauß
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list