[Kde-pim] Review Request 109714: Refactor messagecomposer::Composer::composeStep2

[Sandro Knauß]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109714/
-----------------------------------------------------------

(Updated March 30, 2013, 6:11 p.m.)


Status
------

This change has been discarded.


Review request for KDEPIM.


Description
-------

There are many different methods that chain the mail to the Sign- and EncptionJobs.
To make it more easier to read and unterstand, what's actuallay happaning, all the chaining through
the Sign- and EncyptionJobs are now made directly in composeStep2.

Please also look at #109710, where the createEncryptJobs method was added.


Diffs
-----

  messagecomposer/composer.h 2f6edf2ba2dd2fd44d0b24d2c27b2521bceb3177 
  messagecomposer/composer.cpp 763cd02afedda8ffa0fce0c3c997d5bf755c2b20 

Diff: http://git.reviewboard.kde.org/r/109714/diff/


Testing
-------

compiling, creating signed and encrypted mails (inline, pgp mime, SMIME and SMIME Opaque) with attachments and without.


Thanks,

Sandro Knauß

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/