[Kde-pim] Review Request 101809: Fix custom field handling in KDEPimLibs

[Torgny Nyblom]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101809/
-----------------------------------------------------------

(Updated March 12, 2013, 7:15 p.m.)


Status
------

This change has been discarded.


Review request for KDEPIM-Libraries and Tobias Koenig.


Description
-------

There where several bugs in the custom field handling of KDEPimLibs (I found them in KAddressbook):
1. the type was not loaded correctly when showing a contact's information
2. the type of a field was not load correctly when editing a contact
3. the global fields where not loaded for a new contact and therefore deleted as the save function deletes all global fields and readds them from the current contact.

This patch fixes all of them (per bug one line change). I am pretty sure that the first two bugs are fixed properly. The last bug is fixed by loading all global fields in the constructor. If I understood the code correctly that should be okay as all fields are reloaded when loading a contact so no duplicates should occur.


Diffs
-----

  akonadi/contact/contactviewer.cpp 9b0469b 
  akonadi/contact/customfieldmanager.cpp 90df0b6 
  akonadi/contact/editor/customfieldseditwidget.cpp e36144b 

Diff: http://git.reviewboard.kde.org/r/101809/diff/


Testing
-------

Tested with a few contacts.


Thanks,

Jan Gerrit Marker

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/