[Kde-pim] Review Request 102594: Add isConfiguring method to AgentBase to easily limit to one configuration dialog per agent.

[Torgny Nyblom]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102594/
-----------------------------------------------------------

(Updated March 12, 2013, 7:13 p.m.)


Status
------

This change has been discarded.


Review request for Akonadi, KDEPIM and KDEPIM-Libraries.


Description
-------

While investigating https://bugs.kde.org/show_bug.cgi?id=247299, I discovered that any and all akonadi agents can open multiple configuration dialogs at the same time. My opinion on this matter is that this shouldn't be possible, so I modified slightly AgentBase to add the isConfiguring() method which is designed to only be called from within the configure() function of an agent. I did it this way so as to minimize the burden on agent implementors.


Diffs
-----

  akonadi/agentbase.h 4751c02 
  akonadi/agentbase.h 4751c02 
  akonadi/agentbase.cpp 6d3bf83 
  akonadi/agentbase.cpp 6d3bf83 
  akonadi/agentbase_p.h 988fb1a 
  akonadi/agentbase_p.h 988fb1a 

Diff: http://git.reviewboard.kde.org/r/102594/diff/


Testing
-------

Modified the imap resource : added if ( isConfiguring() ) return; at the beginning of the configure() function. Compiled, ran.
The modify button in akonadi configuration opened a configuration dialog when none was showing, and did nothing when one was already showing. As expected.


Thanks,

Martin Bednar

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/