[Kde-pim] Review Request 108974: Escape UIDs in resources that use them as filename

[Dan Vrátil]

> On March 10, 2013, 1:25 p.m., Grégory Oestreicher wrote:
> > Thanks for this patch. You can apply r1 to the DAV resource, and I'll take care of porting r2.
> > 
> > Cheers,
> > Grégory

Can someone please review r2? If Gregory's fine with pushing DAV part of r1 as fix for the DAV resource, the r2 can now be considered complete.


- Dan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108974/#review28877
-----------------------------------------------------------


On Feb. 27, 2013, 3:39 p.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108974/
> -----------------------------------------------------------
> 
> (Updated Feb. 27, 2013, 3:39 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> Contacts, vcarddir, icaldir and dav resources use KABC::Addressee::uid() or KCalCore::Incidence::uid() as part of the destination filenames. This fails if the UID contains unsafe characters like path delimiter, colon etc.
> 
> This patch uses QUrl::toPercentEncoding() to make sure the UID is safe to use.
> 
> 
> Diffs
> -----
> 
>   resources/contacts/contactsresource.h ce92d6d 
>   resources/contacts/contactsresource.cpp 499f56e 
>   resources/icaldir/icaldirresource.h 8fe7733 
>   resources/icaldir/icaldirresource.cpp d653220 
>   resources/vcarddir/vcarddirresource.h 1423bdf 
>   resources/vcarddir/vcarddirresource.cpp e5d5ded 
> 
> Diff: http://git.reviewboard.kde.org/r/108974/diff/
> 
> 
> Testing
> -------
> 
> Successfully copied a contact from akonadi_googlecontacts_resource (which uses full http:// URL as UID) to akonadi_contacts_resource (which uses ~/.local/contacts/%contactUID%.vcard as filename).
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/