[Kde-pim] coding-style for KDEPIM

[David Jarvie]

On Thursday 07 March 2013 16:19:32 John Layt wrote:
> On 7 March 2013 15:26, Allen Winter <winter at kde.org> wrote:
> > On Thursday 07 March 2013 11:26:43 AM Guy Maurel wrote:
> >> As discussed at the KDEPIM meeting, Berlin, 3 March 2013, all the files of
> >> KDEPIM will be reviewed to follow the coding style. This will be done over a
> >> long time, directory after directory, for each of the rules.
> >>
> >> I opened a new URL for that:
> >>    http://techbase.kde.org/Policies/Kdepim_Coding_Style
> >>
> >> This is still in construction.
> >> Please, have a look to my proposal and comment it.
> >> Any suggestions, fixes are welcome.
> >>
> > Guy,
> > We already have a coding style page at
> > http://community.kde.org/KDE_PIM/Development/CodingStyle/Korganizer
> >
> > So you can copy that in and make changes as needed.
> > Then remove it.
> >
> > I do object to the 4 space indent level. I like 2 better.
> > especially if we keep to a 100-char line length limit.
> >
> > I need to change Krazy checker accordingly.
> >
> > Why can't we do one big astyle change all in one go?
> 
> To fill in a few details, the decision was taken to get our style as
> close to kdelibs and Qt as possible to remove the barrier for new
> users and contributors from the Qt world and kdelibs.  It's also going
> to be a requirement for KDE Frameworks 5 inclusion where we want to
> move many of the libraries.  Personally, having to remember all the
> small style differences between Qt, kdelibs and kdepimlibs is annoying
> and frustrating and creates rework for me.
> 
> It was also decided that changing style will only be done with the
> agreement of each library's maintainer, for example David can opt not
> to have the KAlarm libraries converted.  However it is preferred to
> move to kdelibs style.

If the aim is to move to the Qt coding style for the reasons you state, I would be ok with that for the libraries at least. The reasoning you give for changing kdepim's style seem reasonable, especially since they argue the case from a practical rather than stylistic point of view.

Qt's style, while not perfect from my point of view (there can of course only be one true style ;) ), would be acceptable to me as a compromise. The KOrganizer style would not be.

-- 
David Jarvie.
KDE developer.
KAlarm author -- http://www.astrojar.org.uk/kalarm
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/