[Kde-pim] Review Request 109272: Fixing ContentTransferEncoding for signed&encrypted messages

[Sandro Knauß]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109272/
-----------------------------------------------------------

Review request for KDEPIM.


Description
-------

This patch sets proper contentTransferEncoding for singend and/or encryted messages for any mails with non ascii characters.

Therefor the encrypted/signed body will be push through a SinglepartJob to etablished the best matching contentTransferEncoding.


This addresses bugs 289722 and 289728.
    http://bugs.kde.org/show_bug.cgi?id=289722
    http://bugs.kde.org/show_bug.cgi?id=289728


Diffs
-----

  messagecomposer/util.cpp 114122334e368ac1235f1366504d1f78919cd8f6 

Diff: http://git.reviewboard.kde.org/r/109272/diff/


Testing
-------

We send a mail with a simple content "ä".

Got valid mails:

* GnuPG MIME sign
* GnuPG inline sign
* GnuPG MIME encrypt
* GnuPG inline encrypt
* GnuPG MIME encrypt&sign
* GnuPG inline encrypt&sign

with additional attachments to the mail, we got valid results:
* GnuPG MIME sign
* GnuPG MIME encrypt
* GnuPG MIME encrypt&sign

not passed with attachments (but this is not failed because of this patch):
* GnuPG inline encrypt
* GnuPG inline sign
* GnuPG inline encrypt&sign

not tested are all kinds of S/MIME mails.


Thanks,

Sandro Knauß

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/