[Kde-pim] Review Request 109259: Remove inode/directory from MailCommon::FolderCollectionMonitor

[Laurent Montel]

> On March 3, 2013, 3:10 p.m., Kevin Krammer wrote:
> > According to the commit log this fixed new IMAP resources not showing up:
> > 
> > Fix Bug 301663 - after creating a imap account (using assistent) the
> > folder list is still empty
> > BUG: 301663
> > 
> > Can you check that this still works?
> 
> Volker Krause wrote:
>     Ah, as suspected, I think we fixed this for Google/Facebook/Kolab calendars during the last sprint, and removed similar workarounds there. Of course can't hurt to test that.
> 
> Dan Vrátil wrote:
>     Added a new IMAP account and whole folder tree was loaded and shown correctly.

if it loads correctly new imap account for me  it's ok. Ship it.


- Laurent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109259/#review28442
-----------------------------------------------------------


On March 3, 2013, 2:59 p.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109259/
> -----------------------------------------------------------
> 
> (Updated March 3, 2013, 2:59 p.m.)
> 
> 
> Review request for KDEPIM and Laurent Montel.
> 
> 
> Description
> -------
> 
> Don't watch collections in KMail that KMail is not really interested in. This should improve performance a bit and fix a problem, that removing a completely unrelated resource (like Google Calendar) was totally messing up KMail's folder view (usually leading to crash).
> 
> I assume this was added as a workaround for a bug in Monitor, that collections trees where the root collection did not match the mimetype filter were ignored. This has been fixed some time ago, so this is not needed anymore.
> 
> 
> Diffs
> -----
> 
>   mailcommon/foldercollectionmonitor.cpp 49de537 
> 
> Diff: http://git.reviewboard.kde.org/r/109259/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/