[Kde-pim] Review Request 111726: Make use of the CONDSTORE IMAP extension

[Dan Vrátil]

> On July 26, 2013, 6:42 p.m., Kevin Ottens wrote:
> > resources/imap/retrieveitemstask.cpp, line 420
> > <http://git.reviewboard.kde.org/r/111726/diff/1/?file=173855#file173855line420>
> >
> >     Is m_fastSync still needed at all? It was mainly a hack because of the lack of CONDSTORE support, I guess it could be completely cleaned up now.
> >     
> >     Also please make sure to test that there's no side-effect with this change for cases where we have missing bodies (it's kind of fragile). We need to make sure we still support properly going from connected IMAP to disconnected IMAP.

On one side, m_fastSync can be used when the server does not support CONDSTORE. On the other side, that's only minority of servers, so in that case we could do the regular full sync and if people complain, tell them to update their mail server or move to other provider which supports CONDSTORE. So, should I drop it?


- Dan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111726/#review36556
-----------------------------------------------------------


On July 26, 2013, 6:08 p.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111726/
> -----------------------------------------------------------
> 
> (Updated July 26, 2013, 6:08 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> IMAP resource can now sync flag changes at the speed of light ;)
> 
> 
> Diffs
> -----
> 
>   resources/imap/retrieveitemstask.cpp 1df3f6e 
>   resources/imap/retrieveitemstask.h b90cac1 
> 
> Diff: http://git.reviewboard.kde.org/r/111726/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/