[Kde-pim] Review Request 111726: Make use of the CONDSTORE IMAP extension

[Dan Vrátil]

> On July 27, 2013, 10:37 a.m., Volker Krause wrote:
> > Awesome, thanks for looking into supporting CONDSTORE!
> > 
> > How does this behave if the server doesn't support CONDSTORE? Fall back to listing everything automatically because the highest modified sequence number will be 0?

Exactly. When server does not support CONDSTORE, SELECT does not return HIGHESTMODSEQ and SelectJob  will set it to -1 (because 0 is sort-of valid value, according to RFC). FetchJob will then not append CHANGEDSINCE and will simply fetch all emails from the mailbox like it does now.


> On July 27, 2013, 10:37 a.m., Volker Krause wrote:
> > resources/imap/retrieveitemstask.cpp, line 423
> > <http://git.reviewboard.kde.org/r/111726/diff/1/?file=173855#file173855line423>
> >
> >     I might be missing something, but isn't this the code path that handled server-side deletions?
> >     
> >     All the new itemsRetrievedIncremental() calls have empty deletion lists it seems.

Right, this is actually broken.


- Dan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111726/#review36580
-----------------------------------------------------------


On July 26, 2013, 6:08 p.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111726/
> -----------------------------------------------------------
> 
> (Updated July 26, 2013, 6:08 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> IMAP resource can now sync flag changes at the speed of light ;)
> 
> 
> Diffs
> -----
> 
>   resources/imap/retrieveitemstask.cpp 1df3f6e 
>   resources/imap/retrieveitemstask.h b90cac1 
> 
> Diff: http://git.reviewboard.kde.org/r/111726/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/