[Kde-pim] Review Request 111358: kt-lib / kmail-mobile: replace DecoratedFlickable with ScrollArea

[Michael Bohlender]

> On July 3, 2013, 4:21 p.m., Kevin Krammer wrote:
> > mobile/calendar/ConfigDialog.qml, line 70
> > <http://git.reviewboard.kde.org/r/111358/diff/2/?file=167623#file167623line70>
> >
> >     is this change intentional?
> >     i.e. from right: parent.right to okButton.left?

yes. ScrollArea adds a scrollbar/positionIndicator to the flickable. this scrollbar would appear behind the okButton otherwise


- Michael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111358/#review35526
-----------------------------------------------------------


On July 2, 2013, 9:09 p.m., Michael Bohlender wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111358/
> -----------------------------------------------------------
> 
> (Updated July 2, 2013, 9:09 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> Replaces KPIM.DecoratedFlickable with PlasmaExtras.ScrollArea.
> I will do the same for the other kontact-touch application so that I can remove KPIM.DecoratedFlickable entirely. 
> 
> 
> Diffs
> -----
> 
>   mobile/calendar/ConfigDialog.qml ea2337c 
>   mobile/contacts/ConfigDialog.qml 16849b3 
>   mobile/contacts/contact-editor.qml b80a67c 
>   mobile/contacts/contactgroup-editor.qml 9036a98 
>   mobile/lib/AboutDialog.qml 0011f3d 
>   mobile/lib/AttachmentList.qml 7094361 
>   mobile/lib/CMakeLists.txt 030dfa5 
>   mobile/lib/DecoratedFlickable.qml dd05210 
>   mobile/lib/SearchDialog.qml 93804ac 
>   mobile/lib/calendar/incidence-editor.qml cdefc13 
>   mobile/lib/qmldir dcd9601 
>   mobile/mail/ConfigDialog.qml 4efc79e 
>   mobile/mail/kmail-composer.qml 69b0136 
>   mobile/tasks/ConfigDialog.qml a5b03f8 
> 
> Diff: http://git.reviewboard.kde.org/r/111358/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Bohlender
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/