[Kde-pim] Review Request 111358: kt-lib / kmail-mobile: replace DecoratedFlickable with ScrollArea

[Michael Bohlender]

> On July 3, 2013, 4:21 p.m., Kevin Krammer wrote:
> >
> 
> Kevin Krammer wrote:
>     Forgot:
>     there is a bit of inconsistency on how anchors are specified.
>     Some files got changed to use block syntax (anchors {...}) for the grouped property, some other keep listing each subproperty with fully qualified named (anchors.left: ...)

The plasma-qml styling guide (http://community.kde.org/Plasma/QMLStyle) says: anchors.XXX if there is only one property and  anchors { } otherwise. I try to follow this whenever I add something new and I sometimes do it if I move something. but not all the time. I did not want to go through every file and clean it up unless I am sure it is going to stay and not get removed.


- Michael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111358/#review35526
-----------------------------------------------------------


On July 2, 2013, 9:09 p.m., Michael Bohlender wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111358/
> -----------------------------------------------------------
> 
> (Updated July 2, 2013, 9:09 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> Replaces KPIM.DecoratedFlickable with PlasmaExtras.ScrollArea.
> I will do the same for the other kontact-touch application so that I can remove KPIM.DecoratedFlickable entirely. 
> 
> 
> Diffs
> -----
> 
>   mobile/calendar/ConfigDialog.qml ea2337c 
>   mobile/contacts/ConfigDialog.qml 16849b3 
>   mobile/contacts/contact-editor.qml b80a67c 
>   mobile/contacts/contactgroup-editor.qml 9036a98 
>   mobile/lib/AboutDialog.qml 0011f3d 
>   mobile/lib/AttachmentList.qml 7094361 
>   mobile/lib/CMakeLists.txt 030dfa5 
>   mobile/lib/DecoratedFlickable.qml dd05210 
>   mobile/lib/SearchDialog.qml 93804ac 
>   mobile/lib/calendar/incidence-editor.qml cdefc13 
>   mobile/lib/qmldir dcd9601 
>   mobile/mail/ConfigDialog.qml 4efc79e 
>   mobile/mail/kmail-composer.qml 69b0136 
>   mobile/tasks/ConfigDialog.qml a5b03f8 
> 
> Diff: http://git.reviewboard.kde.org/r/111358/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Bohlender
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/