[Kde-pim] Review Request 109924: Only single empty lines, First line, last line(s) may not be empty for kdepimlibs/akonadi

Volker Krause vkrause at kde.org
Tue Jul 30 09:54:45 BST 2013 

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109924/#review36787
-----------------------------------------------------------

Ship it!


Ship It!

- Volker Krause


On April 9, 2013, 12:52 p.m., Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109924/
> -----------------------------------------------------------
> 
> (Updated April 9, 2013, 12:52 p.m.)
> 
> 
> Review request for KDEPIM-Libraries and Volker Krause.
> 
> 
> Description
> -------
> 
> According the discussion in Berlin KDEPIM-Meeting and http://techbase.kde.org/Policies/Kdepim_Coding_Style#Migration
> I remove multi empty lines, first empty line and last empty line(s).
> 
> 
> Diffs
> -----
> 
>   akonadi/agentbase.cpp c22c318 
>   akonadi/agentfactory.cpp f61d8a9 
>   akonadi/agentfilterproxymodel.cpp 7619dd0 
>   akonadi/agentinstance.cpp 8af5edc 
>   akonadi/agentinstancecreatejob.cpp b559c59 
>   akonadi/agentinstancemodel.cpp 500749e 
>   akonadi/agentinstancewidget.h e6785ca 
>   akonadi/agentinstancewidget.cpp e2fa1c5 
>   akonadi/agenttypedialog.cpp c20a451 
>   akonadi/agenttypewidget.cpp 8538b1e 
>   akonadi/attribute.cpp 5107915 
>   akonadi/attributefactory.cpp 6e23daf 
>   akonadi/cachepolicy.cpp e4995d0 
>   akonadi/cachepolicypage.cpp 1e2abb1 
>   akonadi/calendar/blockalarmsattribute.cpp 962e98e 
>   akonadi/calendar/calendarbase.cpp 9a6eb4c 
>   akonadi/calendar/calendarclipboard.h 058595b 
>   akonadi/calendar/calendarclipboard.cpp 0bdaf60 
>   akonadi/calendar/calendarclipboard_p.h 45b3e40 
>   akonadi/calendar/calendarmodel.cpp 42559eb 
>   akonadi/calendar/calendarmodel_p.h 27f5bce 
>   akonadi/calendar/history_p.cpp 7766325 
>   akonadi/calendar/incidencechanger_p.h 9c108bf 
>   akonadi/calendar/itiphandler.cpp 343c73b 
>   akonadi/calendar/kcolumnfilterproxymodel.cpp b2fff69 
>   akonadi/calendar/kcolumnfilterproxymodel_p.h 7f3d4c0 
>   akonadi/calendar/mailclient_p.cpp a85b165 
>   akonadi/calendar/publishdialog_p.cpp 12bfadf 
>   akonadi/calendar/standardcalendaractionmanager.cpp f2ef931 
>   akonadi/calendar/tests/incidencechangertest.cpp df08046 
>   akonadi/calendar/tests/mailclienttest.cpp d5d2bfc 
>   akonadi/calendar/utils_p.h 715939a 
>   akonadi/changerecorder.cpp 816b7ec 
>   akonadi/collection.cpp aeb0cab 
>   akonadi/collectioncombobox.cpp 5209343 
>   akonadi/collectioncopyjob.cpp 70f7ac8 
>   akonadi/collectioncreatejob.cpp 574dba4 
>   akonadi/collectiondeletejob.cpp 2c0614f 
>   akonadi/collectiondialog.h d80bc6b 
>   akonadi/collectiondialog_desktop.cpp 1b8d514 
>   akonadi/collectiondialog_mobile.cpp 3de3b3f 
>   akonadi/collectionfilterproxymodel.cpp 32915d3 
>   akonadi/collectionmodel.cpp 885bc5b 
>   akonadi/collectionmodel_p.h d774826 
>   akonadi/collectionmodel_p.cpp 9c31192 
>   akonadi/collectionmodifyjob.cpp ea17127 
>   akonadi/collectionmovejob.cpp f8c922b 
>   akonadi/collectionpropertiesdialog.cpp a9fc89d 
>   akonadi/collectionpropertiespage.cpp dbb1456 
>   akonadi/collectionrequester.cpp 89ee3ac 
>   akonadi/collectionstatistics.cpp 2e05040 
>   akonadi/collectionstatisticsdelegate.cpp 4df46c1 
>   akonadi/collectionstatisticsjob.cpp 4325f0a 
>   akonadi/collectionstatisticsmodel.cpp 24d3557 
>   akonadi/contact/actions/qdialer.h 8702425 
>   akonadi/contact/actions/qekigadialer.h 60a7687 
>   akonadi/contact/actions/qekigadialer.cpp 18e3044 
>   akonadi/contact/actions/qsflphonedialer.h cf7607f 
>   akonadi/contact/actions/qsflphonedialer.cpp 37c9045 
>   akonadi/contact/actions/qskypedialer.cpp c6d6c9d 
>   akonadi/contact/actions/qwincedialer.cpp ca2fd28 
>   akonadi/contact/actions/smsdialog.cpp 30eb7dd 
>   akonadi/contact/autoqpointer_p.h 907b55c 
>   akonadi/contact/contactdefaultactions.cpp 6ec9a9d 
>   akonadi/contact/contacteditor.h cb38e39 
>   akonadi/contact/contacteditor.cpp 24a01c8 
>   akonadi/contact/contacteditordialog.cpp 3942823 
>   akonadi/contact/contactgroupeditor.cpp 7a308cc 
>   akonadi/contact/contactgroupsearchjob.cpp 0f4333c 
>   akonadi/contact/contactgroupviewerdialog.cpp d696bae 
>   akonadi/contact/contactsearchjob.cpp efd3c1c 
>   akonadi/contact/contactsfilterproxymodel.cpp 7c7d43e 
>   akonadi/contact/contactstreemodel.cpp e78de62 
>   akonadi/contact/contactviewerdialog.cpp eac2250 
>   akonadi/contact/editor/addresseditwidget.cpp 55b3a78 
>   akonadi/contact/editor/categorieseditwidget.cpp 98ae487 
>   akonadi/contact/editor/contacteditorwidget.cpp d0355d4 
>   akonadi/contact/editor/customfieldseditwidget.cpp dc0cc6c 
>   akonadi/contact/editor/customfieldsmodel.cpp dc26a6d 
>   akonadi/contact/editor/dateeditwidget.cpp b1e1af2 
>   akonadi/contact/editor/displaynameeditwidget.cpp 6bd0b43 
>   akonadi/contact/editor/emaileditwidget.cpp 3a358eb 
>   akonadi/contact/editor/freebusyeditwidget.cpp 5ae27a5 
>   akonadi/contact/editor/geoeditwidget.cpp 46e88e9 
>   akonadi/contact/editor/im/imdelegate.cpp c5ef2e9 
>   akonadi/contact/editor/im/imeditordialog.cpp 01bbfe9 
>   akonadi/contact/editor/im/imitemdialog.cpp 4f01e80 
>   akonadi/contact/editor/im/immodel.cpp d222534 
>   akonadi/contact/editor/im/improtocols.cpp f566142 
>   akonadi/contact/editor/imagewidget.cpp 459c336 
>   akonadi/contact/editor/imeditwidget.cpp 187a1c0 
>   akonadi/contact/editor/nameeditdialog.cpp 4329a55 
>   akonadi/contact/editor/nameeditwidget.cpp 9d6dd50 
>   akonadi/contact/editor/phoneeditwidget.h e44f8af 
>   akonadi/contact/editor/phoneeditwidget.cpp 800145c 
>   akonadi/contact/editor/secrecyeditwidget.cpp eba4605 
>   akonadi/contact/editor/soundeditwidget.cpp 91f47ba 
>   akonadi/contact/emailaddressselection.cpp fb1658c 
>   akonadi/contact/emailaddressselectionwidget.cpp 0d1c480 
>   akonadi/contact/kcm/kcmakonadicontactactions.cpp c9e650a 
>   akonadi/contact/recentcontactscollectionrequestjob.cpp f65e890 
>   akonadi/contact/standardcontactactionmanager.cpp 66944da 
>   akonadi/contact/standardcontactformatter.cpp 8bbdb5f 
>   akonadi/contact/tests/contactmetadataattributetest.cpp 6af8bd3 
>   akonadi/contact/textbrowser.cpp c2daed9 
>   akonadi/control.h 307c31b 
>   akonadi/dbusconnectionpool.h af880a2 
>   akonadi/dragdropmanager.cpp 6c22bf8 
>   akonadi/entity.cpp 04daf92 
>   akonadi/entitycache_p.h 667672d 
>   akonadi/entitydeletedattribute.h 87a294b 
>   akonadi/entitydeletedattribute.cpp 4b2210d 
>   akonadi/entitydisplayattribute.cpp e74cda3 
>   akonadi/entitymimetypefiltermodel.cpp 4788583 
>   akonadi/entityorderproxymodel.cpp b977a6c 
>   akonadi/entityrightsfiltermodel.cpp a941742 
>   akonadi/entitytreemodel.h d55b73d 
>   akonadi/entitytreemodel.cpp 5030c11 
>   akonadi/entitytreemodel_p.h 570b4c9 
>   akonadi/entitytreemodel_p.cpp 2505fee 
>   akonadi/entitytreeview.h 9e9a7bc 
>   akonadi/entitytreeview.cpp b3e4677 
>   akonadi/erroroverlay.cpp 4e116e6 
>   akonadi/favoritecollectionsmodel.cpp 16debbf 
>   akonadi/firstrun.cpp 2757fec 
>   akonadi/firstrun_p.h 069b005 
>   akonadi/invalidatecachejob.cpp e05fb93 
>   akonadi/item.h 9aa4012 
>   akonadi/item_p.h a3417cf 
>   akonadi/itemcopyjob.cpp 4fc8e0c 
>   akonadi/itemcreatejob.cpp 9d39248 
>   akonadi/itemfetchjob.cpp ecad0fd 
>   akonadi/itemfetchscope.cpp ab98921 
>   akonadi/itemmodel.cpp c3a3dfe 
>   akonadi/itemmodifyjob.cpp d81b443 
>   akonadi/itemmovejob.h d513288 
>   akonadi/itemmovejob.cpp 340b8d9 
>   akonadi/itempayloadinternals_p.h 6665812 
>   akonadi/itemserializerplugin.h 232d67f 
>   akonadi/itemsync.cpp f3ad740 
>   akonadi/itemview.h c2251c0 
>   akonadi/itemview.cpp ffc031c 
>   akonadi/job.cpp 2fa564f 
>   akonadi/kdsignalblocker.cpp 5a5782e 
>   akonadi/kmime/addressattribute.h 9ae4f87 
>   akonadi/kmime/commandbase.cpp 4479e44 
>   akonadi/kmime/commandbase_p.h 348bd7b 
>   akonadi/kmime/emptytrashcommand.cpp f2060bb 
>   akonadi/kmime/emptytrashcommand_p.h e2d0dea 
>   akonadi/kmime/markascommand.cpp 1563b38 
>   akonadi/kmime/messagefolderattribute.cpp f99410a 
>   akonadi/kmime/messagemodel.cpp 56217ce 
>   akonadi/kmime/messagestatus.cpp 24d5e2f 
>   akonadi/kmime/messagethreaderproxymodel.cpp cf83744 
>   akonadi/kmime/movecommand.cpp 1a47284 
>   akonadi/kmime/movecommand_p.h 709517b 
>   akonadi/kmime/movetotrashcommand.cpp 8a10e4a 
>   akonadi/kmime/movetotrashcommand_p.h 49f6fab 
>   akonadi/kmime/removeduplicatesjob.cpp b0c2fc6 
>   akonadi/kmime/specialmailcollections.cpp 191c3d8 
>   akonadi/kmime/specialmailcollectionsdiscoveryjob.h 9095e53 
>   akonadi/kmime/specialmailcollectionsrequestjob.cpp a277494 
>   akonadi/kmime/standardmailactionmanager.cpp dad0cdc 
>   akonadi/kmime/tests/foldersrequester.h ae21854 
>   akonadi/kmime/tests/foldersrequester.cpp 1217d9f 
>   akonadi/kmime/tests/localfoldersrequestjobtest.cpp fab21e2 
>   akonadi/kmime/tests/localfolderstest.cpp 52ce8c7 
>   akonadi/kmime/tests/racetest.h b075af4 
>   akonadi/kmime/tests/racetest.cpp fea5d8f 
>   akonadi/kmime/util.cpp 2f2b28a 
>   akonadi/kmime/util_p.h f00e9c3 
>   akonadi/linkjob.cpp d47cdcd 
>   akonadi/monitor.h ef77be1 
>   akonadi/monitor.cpp 88815e0 
>   akonadi/monitor_p.h ec52f11 
>   akonadi/monitor_p.cpp 7996495 
>   akonadi/notes/noteutils.cpp 34d9ed2 
>   akonadi/pastehelper_p.h fab9077 
>   akonadi/pluginloader.cpp f6d2050 
>   akonadi/preprocessorbase_p.cpp e81744e 
>   akonadi/progressspinnerdelegate.cpp 4502b69 
>   akonadi/progressspinnerdelegate_p.h 7ddf2d8 
>   akonadi/recentcollectionaction_p.h 05024a1 
>   akonadi/recursivecollectionfilterproxymodel.h 82c3c0b 
>   akonadi/renamefavoritedialog.h 7be2b4e 
>   akonadi/renamefavoritedialog.cpp 105bc64 
>   akonadi/resourcebase.cpp faaf573 
>   akonadi/resourcesettings.h a3c3133 
>   akonadi/resourcesettings.cpp 9037508 
>   akonadi/searchcreatejob.cpp 15de0e2 
>   akonadi/selectionproxymodel.cpp 6a05a4d 
>   akonadi/selftestdialog.cpp 9231722 
>   akonadi/session.h d8b2b1b 
>   akonadi/session.cpp 3ff021d 
>   akonadi/socialutils/imageprovider.cpp 148a40a 
>   akonadi/socialutils/serializer/akonadi_serializer_socialfeeditem.cpp a9bb108 
>   akonadi/socialutils/tests/image-provider-tests.h e3fa265 
>   akonadi/socialutils/tests/image-provider-tests.cpp bed4f8b 
>   akonadi/specialcollections.cpp 82741bf 
>   akonadi/specialcollectionshelperjobs.cpp a35a84e 
>   akonadi/specialcollectionshelperjobs_p.h d56e6cc 
>   akonadi/specialcollectionsrequestjob.cpp 018f72b 
>   akonadi/standardactionmanager.cpp 27c81de 
>   akonadi/statisticsproxymodel.h 44ae768 
>   akonadi/statisticsproxymodel.cpp 6237da6 
>   akonadi/subscriptiondialog.cpp e5a8ac6 
>   akonadi/tests/actionstatemanagertest.cpp 9e91087 
>   akonadi/tests/agentinstancewidgettest.cpp 1e7ed35 
>   akonadi/tests/agenttypewidgettest.cpp ef7adab 
>   akonadi/tests/attributefactorytest.h db391d0 
>   akonadi/tests/attributefactorytest.cpp 9c78d14 
>   akonadi/tests/autoincrementtest.cpp 55fa4e4 
>   akonadi/tests/benchmarker/maildir/maildir20percentread.h a60bccb 
>   akonadi/tests/benchmarker/maildir/maildir20percentread.cpp e8b1c70 
>   akonadi/tests/benchmarker/maildir/maildirfetchallheaders.h 994809b 
>   akonadi/tests/benchmarker/maildir/maildirfetchallheaders.cpp 47d1519 
>   akonadi/tests/benchmarker/maildir/maildirfetchunreadheaders.h ead1f86 
>   akonadi/tests/benchmarker/maildir/maildirfetchunreadheaders.cpp 9c5a912 
>   akonadi/tests/benchmarker/maildir/maildirimport.h 26dac76 
>   akonadi/tests/benchmarker/maildir/maildirimport.cpp 2e34fea 
>   akonadi/tests/benchmarker/maildir/maildirremovereadmessages.h 2e84ab8 
>   akonadi/tests/benchmarker/maildir/maildirremovereadmessages.cpp e15da07 
>   akonadi/tests/benchmarker/testmaildir.h aa09b8f 
>   akonadi/tests/collectionattributetest.h 3b49c43 
>   akonadi/tests/collectionattributetest.cpp ceb4de1 
>   akonadi/tests/collectionjobtest.h 863885e 
>   akonadi/tests/collectionjobtest.cpp 298f489 
>   akonadi/tests/collectionpathresolvertest.h 11a1a40 
>   akonadi/tests/entitydisplayattributetest.cpp 8c300aa 
>   akonadi/tests/entitytreemodeltest.cpp 42a33cb 
>   akonadi/tests/etm_test_app/main.cpp 4af252a 
>   akonadi/tests/etm_test_app/mainwindow.cpp 9d21550 
>   akonadi/tests/fakeentitycache.h 1ec1d6a 
>   akonadi/tests/fakeentitycache.cpp 878aef7 
>   akonadi/tests/fakemonitor.h 0cc0b0c 
>   akonadi/tests/fakemonitor.cpp 4064766 
>   akonadi/tests/fakeserverdata.cpp fffb0c1 
>   akonadi/tests/fakesession.h 9f19ba1 
>   akonadi/tests/fakesession.cpp b931d6c 
>   akonadi/tests/headfetcher.cpp 09710bd 
>   akonadi/tests/imapparsertest.h 45f5812 
>   akonadi/tests/imapparsertest.cpp 8ab95a3 
>   akonadi/tests/imapsettest.h 9713e46 
>   akonadi/tests/inspectablechangerecorder.cpp 5c9f34b 
>   akonadi/tests/inspectablemonitor.cpp 5cf9469 
>   akonadi/tests/itemappendtest.h 36bef5b 
>   akonadi/tests/itemappendtest.cpp 284d177 
>   akonadi/tests/itemdumper.h 168b134 
>   akonadi/tests/itemdumper.cpp 63c87c2 
>   akonadi/tests/itemfetchtest.h 167fef2 
>   akonadi/tests/itemfetchtest.cpp f91af16 
>   akonadi/tests/itemhydratest.cpp ce92537 
>   akonadi/tests/itemserializertest.h de545f9 
>   akonadi/tests/itemserializertest.cpp e7a9f48 
>   akonadi/tests/itemstoretest.cpp dccc527 
>   akonadi/tests/itemtest.h cd6112e 
>   akonadi/tests/mimetypecheckertest.h 9008849 
>   akonadi/tests/modelspy.h 100478b 
>   akonadi/tests/modelspy.cpp c50f66a 
>   akonadi/tests/monitortest.cpp 2b5aa47 
>   akonadi/tests/proxymodelstest.cpp 7ed26e7 
>   akonadi/tests/resourceschedulertest.cpp 4912f5b 
>   akonadi/tests/searchjobtest.h babbbae 
>   akonadi/tests/test_utils.h 2f5405a 
>   akonadi/tests/testrunner/config.cpp 14721a6 
>   akonadi/tests/testrunner/main.cpp 6d7d0cc 
>   akonadi/tests/testrunner/setup.cpp 2850e6a 
>   akonadi/tests/testrunner/shellscript.cpp 21132a9 
>   akonadi/tests/testrunner/symbols.cpp 8184e9e 
>   akonadi/tests/testrunner/testrunner.cpp 6f63f81 
>   akonadi/tests/transactiontest.cpp ec4f370 
>   akonadi/transactionjobs.h eb757d1 
>   akonadi/transactionjobs.cpp 4d3bc48 
>   akonadi/transactionsequence.cpp 45def1f 
>   akonadi/trashfilterproxymodel.cpp 1de8f34 
>   akonadi/trashjob.cpp 5a64908 
>   akonadi/trashrestorejob.cpp af6a7b3 
>   akonadi/trashsettings.h 93e3c50 
>   akonadi/typepluginloader.cpp 47683c8 
>   akonadi/typepluginloader_p.h 659638c 
>   akonadi/unlinkjob.cpp 51b168a 
> 
> Diff: http://git.reviewboard.kde.org/r/109924/diff/
> 
> 
> Testing
> -------
> 
> Tested for CMAKE_BUILD_TYPE "release" and "debug" with http://techbase.kde.org/Policies/Kdepim_Coding_Style#Check_the_assembler_files
> 
> 
> Thanks,
> 
> Guy Maurel
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/

More information about the kde-pim mailing list