[Kde-pim] Review Request 111677: Cleanup/Fix compiler flag handling

[Christophe Giboudeaux]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111677/#review36472
-----------------------------------------------------------

Ship it!


Ship It!


CMakeLists.txt
<http://git.reviewboard.kde.org/r/111677/#comment26918>

    -W is deprecated, please use -Wextra
    
    


- Christophe Giboudeaux


On July 25, 2013, 6:15 a.m., Volker Krause wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111677/
> -----------------------------------------------------------
> 
> (Updated July 25, 2013, 6:15 a.m.)
> 
> 
> Review request for Akonadi, Christophe Giboudeaux and Dan Vrátil.
> 
> 
> Description
> -------
> 
> Fix full rebuilds triggered by forcing increasing CMAKE_CXX_FLAGS variables into the cache, and misc cleanups in this area while being at it.
> 
> 
> Git Log:
> 
> Remove -ansi and -Wno-long-long, conflicting/obsolete with C++11.
> 
> 
> Don't force CMAKE_C[XX]_FLAGS into the cache.
> 
> This causes the flags in the cache to grow with every cmake re-run, and
> forcing a complete rebuild since the compiler flags changed.
> 
> 
> xsltproc is required, so this condition is pointless.
> 
> 
> Merge compiler flag sections.
> 
> 
> Remove non-functional CPack section
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt ef25a24b7bdcdea6a9314231008c121be68f7630 
> 
> Diff: http://git.reviewboard.kde.org/r/111677/diff/
> 
> 
> Testing
> -------
> 
> Doesn't rebuild completely anymore when touching a CMakeLists.txt.
> 
> 
> Thanks,
> 
> Volker Krause
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/