[Kde-pim] Review Request 111677: Cleanup/Fix compiler flag handling
Commit Hook
null at kde.org
Thu Jul 25 10:23:17 BST 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111677/
-----------------------------------------------------------
(Updated July 25, 2013, 9:23 a.m.)
Status
------
This change has been marked as submitted.
Review request for Akonadi, Christophe Giboudeaux and Dan Vrátil.
Description
-------
Fix full rebuilds triggered by forcing increasing CMAKE_CXX_FLAGS variables into the cache, and misc cleanups in this area while being at it.
Git Log:
Remove -ansi and -Wno-long-long, conflicting/obsolete with C++11.
Don't force CMAKE_C[XX]_FLAGS into the cache.
This causes the flags in the cache to grow with every cmake re-run, and
forcing a complete rebuild since the compiler flags changed.
xsltproc is required, so this condition is pointless.
Merge compiler flag sections.
Remove non-functional CPack section
Diffs
-----
CMakeLists.txt ef25a24b7bdcdea6a9314231008c121be68f7630
Diff: http://git.reviewboard.kde.org/r/111677/diff/
Testing
-------
Doesn't rebuild completely anymore when touching a CMakeLists.txt.
Thanks,
Volker Krause
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
More information about the kde-pim
mailing list