[Kde-pim] Review Request 108617: extern "C" back to ktexteditorkabcbridge

[Laurent Montel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108617/#review26280
-----------------------------------------------------------

Ship it!


Ship it.
please apply to 4.10 and we will merge in master (not cherry picked please)

Thanks for fixing it

- Laurent Montel


On Jan. 27, 2013, 3:57 p.m., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108617/
> -----------------------------------------------------------
> 
> (Updated Jan. 27, 2013, 3:57 p.m.)
> 
> 
> Review request for KDEPIM and Jaime Torres Amate.
> 
> 
> Description
> -------
> 
> this revert be9735631711bdfaadb1a5f8795b82bc7356b421
> 
> extern "C" should have no side effect on returning a class if only if the code will be used in C++ code, but will only bring a simpler name.
> 
> This break the kate template plugin. (I guess it's the only user of this function?)
> 
> 
> Diffs
> -----
> 
>   plugins/ktexteditor/ktexteditorkabcbridge.cpp a8f9e3c 
> 
> Diff: http://git.reviewboard.kde.org/r/108617/diff/
> 
> 
> Testing
> -------
> 
> kate template is now working.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/