[Kde-pim] Review Request 108617: extern "C" back to ktexteditorkabcbridge
Xuetian Weng
wengxt at gmail.com
Sun Jan 27 19:06:26 GMT 2013
> On Jan. 27, 2013, 7 p.m., Laurent Montel wrote:
> > How we use it ?
> > just for testing your patch .
http://quickgit.kde.org/?p=kate.git&a=blob&f=ktexteditor%2Ftemplateinterface.cpp
line 62 - 64
Kate -> enable template plugin, file -> new from template
- Xuetian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108617/#review26272
-----------------------------------------------------------
On Jan. 27, 2013, 3:57 p.m., Xuetian Weng wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108617/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2013, 3:57 p.m.)
>
>
> Review request for KDEPIM and Jaime Torres Amate.
>
>
> Description
> -------
>
> this revert be9735631711bdfaadb1a5f8795b82bc7356b421
>
> extern "C" should have no side effect on returning a class if only if the code will be used in C++ code, but will only bring a simpler name.
>
> This break the kate template plugin. (I guess it's the only user of this function?)
>
>
> Diffs
> -----
>
> plugins/ktexteditor/ktexteditorkabcbridge.cpp a8f9e3c
>
> Diff: http://git.reviewboard.kde.org/r/108617/diff/
>
>
> Testing
> -------
>
> kate template is now working.
>
>
> Thanks,
>
> Xuetian Weng
>
>
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
More information about the kde-pim
mailing list