[Kde-pim] Review Request 108485: Merge "Expiry" into "Folder Properties"

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108485/#review25801
-----------------------------------------------------------


This review has been submitted with commit 8ad83768ca26a6cbded59d5f7714bd0d3e1d0b26 by Jonathan Marten to branch master.

- Commit Hook


On Jan. 19, 2013, 3:16 p.m., Jonathan Marten wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108485/
> -----------------------------------------------------------
> 
> (Updated Jan. 19, 2013, 3:16 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> This change merges the separate "Expiry" dialogue into a tab of "Folder Properties".  This is the final change to address bug 115611.
> 
> In order to maintain the same user experience, the actions and menu structure remain unchanged.  The "Expire" option in the folder context menu opens the "Folder Properties" dialogue at the appropriate tab.
> 
> In order to eliminate the long-standing anomaly that changing the expiry settings also triggers an immediate expiry (as noted in comment#1 to the bug) the "OK" button in the tabbed dialogue does not do that, it just saves the settings.  There is an additional "Save settings and expire now" button to do an immediate expiry if required.  There is still an anomaly with the action names and what they do (see comments in kmmainwidget.cpp), but that will be addressed in a separate review.
> 
> This change removes one, changes two and adds one new I18N string.
> 
> 
> This addresses bug 115611.
>     http://bugs.kde.org/show_bug.cgi?id=115611
> 
> 
> Diffs
> -----
> 
>   kmail/kmmainwidget.cpp f65d117 
>   mailcommon/CMakeLists.txt 0832f5e 
>   mailcommon/collectionexpirypage.h PRE-CREATION 
>   mailcommon/collectionexpirypage.cpp PRE-CREATION 
>   mailcommon/expirypropertiesdialog.h 7cc1d22 
>   mailcommon/expirypropertiesdialog.cpp 7ae1a1d 
> 
> Diff: http://git.reviewboard.kde.org/r/108485/diff/
> 
> 
> Testing
> -------
> 
> Built kdepim with this change, checked operation of dialogue and expiry options.
> 
> 
> Thanks,
> 
> Jonathan Marten
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/