[Kde-pim] Review Request 114505: ItemFetchJob: Add setCollectItems
Christian Mollekopf
chrigi_1 at fastmail.fm
Tue Dec 17 17:57:01 GMT 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114505/#review45880
-----------------------------------------------------------
akonadi/itemfetchjob.h
<http://git.reviewboard.kde.org/r/114505/#comment32746>
Since there is no point in this, it should be removed IMO.
- Christian Mollekopf
On Dec. 17, 2013, 5:52 p.m., Vishesh Handa wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114505/
> -----------------------------------------------------------
>
> (Updated Dec. 17, 2013, 5:52 p.m.)
>
>
> Review request for KDEPIM.
>
>
> Repository: kdepimlibs
>
>
> Description
> -------
>
> This allows us to control if the items being fetched are internally
> collected in order to be accessed later via the items() function.
>
> We want to disable this in the case of email indexing where every
> item in every collection is loaded into memory along with its entire
> payload. Collecting everything results in very high memory usage.
>
>
> Diffs
> -----
>
> akonadi/itemfetchjob.h f9c52a2
> akonadi/itemfetchjob.cpp 93168c3
>
> Diff: http://git.reviewboard.kde.org/r/114505/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Vishesh Handa
>
>
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
More information about the kde-pim
mailing list