[Kde-pim] Review Request 114505: ItemFetchJob: Add setCollectItems

[Kevin Krammer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114505/#review45881
-----------------------------------------------------------



akonadi/itemfetchjob.h
<http://git.reviewboard.kde.org/r/114505/#comment32747>

    that doesn't look right, I think that macro only takes one argument, no?



akonadi/itemfetchjob.h
<http://git.reviewboard.kde.org/r/114505/#comment32748>

    Just some brainstorming for names:
    EmitSingleItem or EmitItemsIndividually
    he bulk one could then be
    EmitItemBatches or EmitItemsInBatches
    



akonadi/itemfetchjob.cpp
<http://git.reviewboard.kde.org/r/114505/#comment32749>

    could probably be moved to the initialisation list



akonadi/itemfetchjob.cpp
<http://git.reviewboard.kde.org/r/114505/#comment32750>

    need to move out of the if



akonadi/itemfetchjob.cpp
<http://git.reviewboard.kde.org/r/114505/#comment32751>

    else if up to previous line


On thing regarding flag names is if we want to have an option to create item batches for signal emit based on number rather than time. E.g. emit every "n" items, like paging?
Doesn't have to be added right now but flag names should already be chosen so that the new one fits in afterwards

- Kevin Krammer


On Dec. 17, 2013, 5:52 p.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114505/
> -----------------------------------------------------------
> 
> (Updated Dec. 17, 2013, 5:52 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
>     This allows us to control if the items being fetched are internally
>     collected in order to be accessed later via the items() function.
>     
>     We want to disable this in the case of email indexing where every
>     item in every collection is loaded into memory along with its entire
>     payload. Collecting everything results in very high memory usage.
> 
> 
> Diffs
> -----
> 
>   akonadi/itemfetchjob.h f9c52a2 
>   akonadi/itemfetchjob.cpp 93168c3 
> 
> Diff: http://git.reviewboard.kde.org/r/114505/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/