[Kde-pim] Review Request 114505: ItemFetchJob: Add setCollectItems

[Kevin Krammer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114505/#review45805
-----------------------------------------------------------



akonadi/itemfetchjob.h
<http://git.reviewboard.kde.org/r/114505/#comment32723>

    I don't think this needs a default value for the argument.
    The only reason to call it would be to disable it and then you need to pass "false" anyway



akonadi/itemfetchjob.cpp
<http://git.reviewboard.kde.org/r/114505/#comment32724>

    block braces


I would suggest we look at this in a slightly more flexible context, i.e. delivery option flags.
e.g.:

enum DeliveryOption {
  None = 0x0,            // no item delivery, not really useful
  ItemGetter = 0x1,      // items available through items()
  ImmediateSignal = 0x2, // emitted via signal upon reception
  BulkSignal = 0x4,      // emitted via signal in bulk (collected and emitted delayed via timer)
  Default = ItemGetter | BulkSignal
};
Q_FLAGS(DeliverOptions, DeliveryOption);

- Kevin Krammer


On Dec. 16, 2013, 6:31 p.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114505/
> -----------------------------------------------------------
> 
> (Updated Dec. 16, 2013, 6:31 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
>     This allows us to control if the items being fetched are internally
>     collected in order to be accessed later via the items() function.
>     
>     We want to disable this in the case of email indexing where every
>     item in every collection is loaded into memory along with its entire
>     payload. Collecting everything results in very high memory usage.
> 
> 
> Diffs
> -----
> 
>   akonadi/itemfetchjob.cpp 93168c3 
>   akonadi/itemfetchjob.h f9c52a2 
> 
> Diff: http://git.reviewboard.kde.org/r/114505/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/