[Kde-pim] Review Request 114505: ItemFetchJob: Add setCollectItems

[Christian Mollekopf]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114505/#review45804
-----------------------------------------------------------



akonadi/itemfetchjob.h
<http://git.reviewboard.kde.org/r/114505/#comment32722>

    Perhaps adjust the documentation to include the full description on the setter:
    
    "Specifies if the items should be collected for the items() function. The itemsReceived() signal is emitted in any case with the items as they are received.
    By default this is true.
    
    @see items()
    @see itemsReceived()
    @since 4.13
    "
    
    "Indicates if the items are collected for the items() function.
    
    @see setCollectItems
    @since 4.13"


- Christian Mollekopf


On Dec. 16, 2013, 6:31 p.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114505/
> -----------------------------------------------------------
> 
> (Updated Dec. 16, 2013, 6:31 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
>     This allows us to control if the items being fetched are internally
>     collected in order to be accessed later via the items() function.
>     
>     We want to disable this in the case of email indexing where every
>     item in every collection is loaded into memory along with its entire
>     payload. Collecting everything results in very high memory usage.
> 
> 
> Diffs
> -----
> 
>   akonadi/itemfetchjob.cpp 93168c3 
>   akonadi/itemfetchjob.h f9c52a2 
> 
> Diff: http://git.reviewboard.kde.org/r/114505/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/