[Kde-pim] Review Request 110592: Serializer for ContactGroup2

[Volker Krause]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110592/#review36981
-----------------------------------------------------------



plugins/akonadi_serializer_contactgroup2.desktop
<http://git.reviewboard.kde.org/r/110592/#comment27278>

    Do we need dedicated mimetypes for this, like we have for detecting event/task sub-types?
    
    Also, did you test how this behaves having the same mimetype as the KABC::Addressee serializer? This works in theory (see KCal vs. KCalCore), but there it's just different implementations of the same object, not entirely different things, content-wise.


- Volker Krause


On May 22, 2013, 10:59 a.m., Christian Mollekopf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110592/
> -----------------------------------------------------------
> 
> (Updated May 22, 2013, 10:59 a.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> Serializer for ContactGroup2
> 
> 
> Diffs
> -----
> 
>   plugins/CMakeLists.txt 9f4bf4604d6e0e1ce28d2c5a0b34e19f67091e32 
>   plugins/akonadi_serializer_contactgroup2.cpp PRE-CREATION 
>   plugins/akonadi_serializer_contactgroup2.desktop PRE-CREATION 
>   plugins/akonadi_serializer_contactgroup2.h PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/110592/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Christian Mollekopf
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/