[Kde-pim] Review Request 111741: Implements --query command

[Kevin Krammer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111741/#review36993
-----------------------------------------------------------



kleopatra/commands/lookupcertificatescommand.cpp
<http://git.reviewboard.kde.org/r/111741/#comment27303>

    I would suggest to move this to the other Qt includes below



kleopatra/dialogs/lookupcertificatesdialog.h
<http://git.reviewboard.kde.org/r/111741/#comment27305>

    I think ED is just used for the variable name because it is a line edit, so setFindText or maybe even setSearchText would be better IMHO



kleopatra/dialogs/lookupcertificatesdialog.h
<http://git.reviewboard.kde.org/r/111741/#comment27304>

    no "get" in Qt getters



kleopatra/kleopatraapplication.cpp
<http://git.reviewboard.kde.org/r/111741/#comment27297>

    sorry, style nitpick again
    spaces around "query"



kleopatra/kleopatraapplication.cpp
<http://git.reviewboard.kde.org/r/111741/#comment27298>

    spaces around "parent-windowid"



kleopatra/kleopatraapplication.cpp
<http://git.reviewboard.kde.org/r/111741/#comment27299>

    commented out code?



kleopatra/kleopatraapplication.cpp
<http://git.reviewboard.kde.org/r/111741/#comment27300>

    spaces around key.isNull()



kleopatra/kleopatraapplication.cpp
<http://git.reviewboard.kde.org/r/111741/#comment27302>

    remove one space before 0



kleopatra/kleopatraapplication.cpp
<http://git.reviewboard.kde.org/r/111741/#comment27301>

    space after 0


- Kevin Krammer


On Aug. 2, 2013, 12:59 p.m., Lindsay Mathieson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111741/
> -----------------------------------------------------------
> 
> (Updated Aug. 2, 2013, 12:59 p.m.)
> 
> 
> Review request for Akonadi, Lindsay Mathieson and Volker Krause.
> 
> 
> Description
> -------
> 
> Added support for "--query <fingerprint>" command. Pre-loads search field and starts default keyserver search.
> 
> 
> This addresses bug 175980.
>     http://bugs.kde.org/show_bug.cgi?id=175980
> 
> 
> Diffs
> -----
> 
>   kleopatra/commands/lookupcertificatescommand.h 80215fd 
>   kleopatra/commands/lookupcertificatescommand.cpp 7f96146 
>   kleopatra/dialogs/lookupcertificatesdialog.h b8fa78f 
>   kleopatra/dialogs/lookupcertificatesdialog.cpp b50bcd4 
>   kleopatra/kleopatraapplication.cpp 13590c9 
> 
> Diff: http://git.reviewboard.kde.org/r/111741/diff/
> 
> 
> Testing
> -------
> 
> Started kleopatra from console with various options such as:
> 
>   kleopatra --query 04b8b187
> 
> Keysearch dialog is displayed with correct parameters.
> 
> 
> Thanks,
> 
> Lindsay Mathieson
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/