[Kde-pim] Review Request 111900: Documentation: Menus.docbook Composer menu Message

[Scarlett Clark]

> On Aug. 6, 2013, 5:16 a.m., Burkhard Lück wrote:
> > doc/kmail/menus.docbook, lines 1086-1095
> > <http://git.reviewboard.kde.org/r/111900/diff/1/?file=176331#file176331line1086>
> >
> >     Are the format changes really necessary?
> >     
> >     Makes it harder to read the diff.
> >     
> >     And the old format is much better readable.
> >     
> >     Please try to keep the format of docbook entries consistent, at least in one docbook/handbook.
> >     
> >     Please look how this is done in kdelibs/kdoctools/template.docbook
> 
> Scarlett Clark wrote:
>     I did not know about this template. Thank you.
> 
> Burkhard Lück wrote:
>     Please don't get me wrong.
>     
>     I did not mean you should change formatting of all varlistentries to the template.docbook style.
>     
>     But please keep the old format, if you only change the content of markup e.g like here:
>     
>     1113 <varlistentry>
>     1114 <term>
>     1115 <menuchoice>
>     1116 <guimenu>Message</guimenu>
>     1117 <guimenuitem>New AddressBook Contact</guimenuitem>
>     1118 </menuchoice>
>     1119 </term>
>     1120 <listitem>
>     1121 <para>Creates a new address book contact.</para>
>     1122 </listitem>
>     1123 </varlistentry>

No you are right. It looks alot better. Kate was indenting my work and that is where it all started with the changes. I was unaware of this great file and wish I would have known about it long ago, but better late than never :). I want to do this the right way and "consistent" as you said. So I am fixing the whole file now.


- Scarlett


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111900/#review37181
-----------------------------------------------------------


On Aug. 5, 2013, 9:07 p.m., Scarlett Clark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111900/
> -----------------------------------------------------------
> 
> (Updated Aug. 5, 2013, 9:07 p.m.)
> 
> 
> Review request for Documentation, KDEPIM and Laurent Montel.
> 
> 
> Description
> -------
> 
> Updated the Message menu in the Composer Window to reflect current build.
> 
> 
> Diffs
> -----
> 
>   doc/kmail/menus.docbook 63023ae 
> 
> Diff: http://git.reviewboard.kde.org/r/111900/diff/
> 
> 
> Testing
> -------
> 
> EBN, checkXML meinproc4 khelpcenter.
> 
> 
> Thanks,
> 
> Scarlett Clark
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/