[Kde-pim] Review Request 111900: Documentation: Menus.docbook Composer menu Message

[Burkhard Lück]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111900/#review37346
-----------------------------------------------------------

Ship it!



doc/kmail/menus.docbook
<http://git.reviewboard.kde.org/r/111900/#comment27624>

    The only "The Foo Menu" in this docbook, anywhere else "Foo Menu" is used.
    Please keep it consistent e.g. by removing "The "here



doc/kmail/menus.docbook
<http://git.reviewboard.kde.org/r/111900/#comment27619>

    You will have a conflict here, because I committed a simple markup fix this morning, but forgot your review, see:
    
    http://commits.kde.org/kdepim/02d987f0845b382ec51954a244fa9fc37fec41d3
    
    Sorry for inconvenience



doc/kmail/menus.docbook
<http://git.reviewboard.kde.org/r/111900/#comment27621>

    Please change
    <literal role="extension">.txt</literal>
    to
    <filename role="extension">.txt</filename>



doc/kmail/menus.docbook
<http://git.reviewboard.kde.org/r/111900/#comment27620>

    Duplicate "available" is not nice, of course not your fault.
    
    Maybe 
    "This will only be available if a printer is connected."
    or
    "This will only be enabled if a printer is available."
    



doc/kmail/menus.docbook
<http://git.reviewboard.kde.org/r/111900/#comment27623>

    <guibutton>Queue</guibutton>



doc/kmail/menus.docbook
<http://git.reviewboard.kde.org/r/111900/#comment27626>

    <term><menuchoice>
    <guimenu>Message List</guimenu>
    <guisubmenu>Sorting</guisubmenu>
    </menuchoice></term>
    
    could probably simplified to
    
    <term><menuchoice>
    <guisubmenu>Sorting</guisubmenu>
    </menuchoice></term>
    
    because this is a sub variablelist of <guisubmenu>Sorting</guisubmenu>
    



doc/kmail/menus.docbook
<http://git.reviewboard.kde.org/r/111900/#comment27628>

    <guimenu>Message List</guimenu> remove as above?



doc/kmail/menus.docbook
<http://git.reviewboard.kde.org/r/111900/#comment27627>

    <guimenu>Message List</guimenu> remove as above?



doc/kmail/menus.docbook
<http://git.reviewboard.kde.org/r/111900/#comment27629>

    <guimenu>Message List</guimenu> remove as above? 



doc/kmail/menus.docbook
<http://git.reviewboard.kde.org/r/111900/#comment27630>

    <guimenu>Message List</guimenu> remove as above? 



doc/kmail/menus.docbook
<http://git.reviewboard.kde.org/r/111900/#comment27631>

    - Headers</guilabel>See
    + Headers</guilabel> See
    -> add missing whitespace


- Burkhard Lück


On Aug. 6, 2013, 10:45 p.m., Scarlett Clark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111900/
> -----------------------------------------------------------
> 
> (Updated Aug. 6, 2013, 10:45 p.m.)
> 
> 
> Review request for Documentation, KDEPIM and Laurent Montel.
> 
> 
> Description
> -------
> 
> Updated the Message menu in the Composer Window to reflect current build.
> 
> 
> Diffs
> -----
> 
>   doc/kmail/menus.docbook 63023ae 
> 
> Diff: http://git.reviewboard.kde.org/r/111900/diff/
> 
> 
> Testing
> -------
> 
> EBN, checkXML meinproc4 khelpcenter.
> 
> 
> Thanks,
> 
> Scarlett Clark
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/