[Kde-pim] Review Request 110011: Fix Bug #282982 - Violation of RfC 2633 Chapter 3.8

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110011/
-----------------------------------------------------------

(Updated April 16, 2013, 1:19 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDEPIM.


Description
-------

Fix Bug #282982 - Violation of RfC 2633 Chapter 3.8

Violation of RfC 2633 Chapter 3.8 - smime.p7m is not recognized as
encrypted mail, not encrypted, displayed in-line when the content-type
is application/octet-stream.

BUG: 282982
FIXED-IN: 4.10.3
REVIEW: 110011


This addresses bug 282982.
    http://bugs.kde.org/show_bug.cgi?id=282982


Diffs
-----

  messageviewer/objecttreeparser.cpp 9ceea2285761632ee49e6a97b50eec82bb6e5581 

Diff: http://git.reviewboard.kde.org/r/110011/diff/


Testing
-------

adding tests mails for this bug under /messageviewer/tests/data/smime-encrypted* .

Open /messageviewer/tests/data/smime-encrypted-octet-stream.mbox:
-> Mail will be shown as Encrypted Message with content:
"The quick brown fox jumped over the lazy dog."

Testing attached mail at bug report.
-> Mail will be shown as Encrypted Message(Decryption not Possible), Reason:No Secret Key
-> an Icon to click at to open the attached file.

Testing with image attached with name "smime.p7m" amd application/octet-stream
-> Mail will be shown as Encrypted Message(Decryption not Possible), Reason: End of File
-> an Icon to click to open the attached file.

run make test


Thanks,

Sandro Knauß

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/