[Kde-pim] Review Request: add Akonadi::CollectionPropertiesDialog::setCurrentPage()

Jonathan Marten jjm at keelhaul.me.uk
Fri Sep 28 14:17:07 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106623/
-----------------------------------------------------------

Review request for KDEPIM-Libraries.


Description
-------

When a CollectionPropertiesDialog is opened, it always shows the first tab page.  In some applications it may be useful to request that the dialogue opens with a specific tab shown, for example if any formerly separate dialogues were to be merged into KMail's "Folder Properties" dialogue.  The action which summoned the original dialogue can remain in the GUI, which will open the combined dialogue with the appropriate tab shown.

This will hopefully reduce user confusion (of the "where has this gone from the menu?" variety).

This change (adding a new non-virtual function) is BC according to
http://techbase.kde.org/Policies/Binary_Compatibility_Issues_With_C++


Diffs
-----

  akonadi/collectionpropertiesdialog.h 9157c96 
  akonadi/collectionpropertiesdialog.cpp fae9761 

Diff: http://git.reviewboard.kde.org/r/106623/diff/


Testing
-------

Built kdepimlibs with this change, and added a testing stub to KMail to call it.  Verified that the specified tab page of the dialogue is shown when it is opened.


Thanks,

Jonathan Marten

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list