[Kde-pim] Review Request: Disable contact searching in message viewer
Andras Mantia
amantia at kde.org
Tue Oct 23 10:01:26 BST 2012
On Tuesday, October 23, 2012 08:42:43 AM Kevin Krammer wrote:
> In that case I would suggest to split the commit.
> one part that makes sense even after the #if #endif has been removed and one
> only deactivating compilation of certain code parts maybe remove the #if
> #endif stuff from this request, commit and then commit the #if #endif in a
> separate commit (without any further review necessary)
What about if Laurent is OK with the ifdef's that I do it like above, and also
fix/merge the other part where a similar code is and commit them separately,
without updating the review request? :) You have to trust me I do it right
though.
Andras
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
More information about the kde-pim
mailing list