[Kde-pim] Review Request: Disable contact searching in message viewer

[Kevin Krammer]

On Tuesday, 2012-10-23, Andras Mantia wrote:
> On Tuesday, October 23, 2012 08:42:43 AM Kevin Krammer wrote:
> > In that case I would suggest to split the commit.
> > one part that makes sense even after the #if #endif has been removed and
> > one only deactivating compilation of certain code parts maybe remove the
> > #if #endif stuff from this request, commit and then commit the #if
> > #endif in a separate commit (without any further review necessary)
> 
> What about if Laurent is OK with the ifdef's that I do it like above, and
> also fix/merge the other part where a similar code is and commit them
> separately, without updating the review request? :) You have to trust me I
> do it right though.

Sure, just wanted to say that those should be committed separately :)

Cheers,
Kevin

-- 
Kevin Krammer, KDE developer, xdg-utils developer
KDE user support, developer mentoring
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 190 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20121023/ffaa5830/attachment.sig>
-------------- next part --------------
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/