[Kde-pim] Review Request: Don't always recompress contact photos when saving

[Kevin Krammer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106745/#review20247
-----------------------------------------------------------



kabc/picture.cpp
<http://git.reviewboard.kde.org/r/106745/#comment15982>

    If only mData is set and mRawData is empty, then this would not be the same output.
    Better keep the old code, but use data() for retrieveing the data (thus covering both cases)



kabc/picture.cpp
<http://git.reviewboard.kde.org/r/106745/#comment15983>

    I think for compatibility you'll need to have it like this
    return s << picture.d->mIntern << picture.d->mUrl << picture.d->mType << picture.data()



kabc/picture.cpp
<http://git.reviewboard.kde.org/r/106745/#comment15984>

    Here you can keep the old code or read into a temporary QImage and call setData on picture



kabc/tests/picturetest.cpp
<http://git.reviewboard.kde.org/r/106745/#comment15986>

    I am not sure here, this changes the test.
    Maybe setData should not overrwite mType if it is set and use mType when serializing if set?



kabc/tests/picturetest.cpp
<http://git.reviewboard.kde.org/r/106745/#comment15987>

    This also changes the test



kabc/vcardtool.cpp
<http://git.reviewboard.kde.org/r/106745/#comment15985>

    I think you'll also need to save the type, otherwise pic will have rawData but no type and saving that would save rawData and empty type information.
    
    Make sure you have a roundtrip unittest for that


- Kevin Krammer


On Oct. 7, 2012, 9:52 a.m., Sebastian Scheibner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106745/
> -----------------------------------------------------------
> 
> (Updated Oct. 7, 2012, 9:52 a.m.)
> 
> 
> Review request for KDEPIM-Libraries.
> 
> 
> Description
> -------
> 
> When changing a contact with a photo, the photo is recompressed when saving (even though the photo wasn't changed). That's because the photo is loaded into a QImage and when the contact is saved, the QImage is compressed as JPEG again (or PNG if it contains an alpha-channel, which most don't).
> 
> This patch stores the raw base64 photo data from the vcard as a QByteArray in KABC::Picture. If the photo is not changed, this QByteArray is simply used when saving the contact, so there's no recompression and quality loss. If the photo was changed it gets compressed as JPEG as before.
> 
> fixes this bug: https://bugs.kde.org/show_bug.cgi?id=307570
> 
> 
> This addresses bug 307570.
>     http://bugs.kde.org/show_bug.cgi?id=307570
> 
> 
> Diffs
> -----
> 
>   kabc/picture.h bf9745c 
>   kabc/picture.cpp 0a51c8b 
>   kabc/tests/picturetest.h 2b33e18 
>   kabc/tests/picturetest.cpp b599b48 
>   kabc/vcardtool.cpp a742788 
> 
> Diff: http://git.reviewboard.kde.org/r/106745/diff/
> 
> 
> Testing
> -------
> 
> compiled kdepimlibs/kabc with kde 4.9.2
> 
> - created a new contact in kaddressbook and added a photo. exported the contact.
> - changed the photo and exported the contact again
> - the image data in the exported file didn't change
> 
> 
> Thanks,
> 
> Sebastian Scheibner
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/