[Kde-pim] Review Request: Don't always recompress contact photos when saving

[Sebastian Scheibner]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106745/
-----------------------------------------------------------

(Updated Oct. 7, 2012, 9:52 a.m.)


Review request for KDEPIM-Libraries.


Changes
-------

adapted operator==, isEmpty, toString, operator<< and operator>> for Pictures with rawData
(I'm not entirely sure with operator>> and operator<< if that causes any compatibility problems)

VCardTool::createPicture now uses Picture::isEmpty()

And I added unit tests to picturetest.cpp


Description
-------

When changing a contact with a photo, the photo is recompressed when saving (even though the photo wasn't changed). That's because the photo is loaded into a QImage and when the contact is saved, the QImage is compressed as JPEG again (or PNG if it contains an alpha-channel, which most don't).

This patch stores the raw base64 photo data from the vcard as a QByteArray in KABC::Picture. If the photo is not changed, this QByteArray is simply used when saving the contact, so there's no recompression and quality loss. If the photo was changed it gets compressed as JPEG as before.

fixes this bug: https://bugs.kde.org/show_bug.cgi?id=307570


This addresses bug 307570.
    http://bugs.kde.org/show_bug.cgi?id=307570


Diffs (updated)
-----

  kabc/picture.h bf9745c 
  kabc/picture.cpp 0a51c8b 
  kabc/tests/picturetest.h 2b33e18 
  kabc/tests/picturetest.cpp b599b48 
  kabc/vcardtool.cpp a742788 

Diff: http://git.reviewboard.kde.org/r/106745/diff/


Testing
-------

compiled kdepimlibs/kabc with kde 4.9.2

- created a new contact in kaddressbook and added a photo. exported the contact.
- changed the photo and exported the contact again
- the image data in the exported file didn't change


Thanks,

Sebastian Scheibner

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/