[Kde-pim] Review Request: Make E-Mail successfully sent / E-Mail sending failed messages prettier

[Kai Uwe Broulik]

> On Oct. 5, 2012, 6:03 a.m., Laurent Montel wrote:
> > agents/maildispatcher/akonadi_maildispatcher_agent.notifyrc, line 180
> > <http://git.reviewboard.kde.org/r/106725/diff/1/?file=88438#file88438line180>
> >
> >     Why use mail-mark-junk and not dialog-error ?

I think it makes the message more recognizeable instead of having a huge generic "saying-nothing" error icon.


- Kai Uwe


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106725/#review19946
-----------------------------------------------------------


On Oct. 4, 2012, 2:33 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106725/
> -----------------------------------------------------------
> 
> (Updated Oct. 4, 2012, 2:33 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> This fixes the E-Mail Successfully Sent (and failed) messages using a hardcoded size pixmap by moving the icon logic to the notifyrc. Also adds a title string that sumarizes the messages. I used "mail-mark-junk" for mail sending failed because I didn’t want to use a generic dialog-error and we don’t have an apporpriate error icon for mails. I think it fits.
> 
> 
> Diffs
> -----
> 
>   agents/maildispatcher/akonadi_maildispatcher_agent.notifyrc b3846c7 
>   agents/maildispatcher/maildispatcheragent.cpp 04543ab 
> 
> Diff: http://git.reviewboard.kde.org/r/106725/diff/
> 
> 
> Testing
> -------
> 
> Tested it on 4.9 (on my project neon akonadi doesnt work) and sent a mail. New pretty messages appeared (see screenshot).
> 
> 
> Screenshots
> -----------
> 
> Prettier notification
>   http://git.reviewboard.kde.org/r/106725/s/754/
> Prettier error notification
>   http://git.reviewboard.kde.org/r/106725/s/755/
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/