[Kde-pim] Review Request: Some changes to socialutils

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107235/
-----------------------------------------------------------

(Updated Nov. 10, 2012, 12:32 p.m.)


Review request for KDEPIM, KDEPIM-Libraries and kdewin.


Changes
-------

Revert the #include <KDateTime> back to forward declaration only.


Description
-------

Thanks to bug 308763 we noticed couple issues, here's what this fixes:

 * Adds assignment operator
 * Moves the private class to separate file
 * Gets rid of PostReply class and replace it with SocialFeedItem itself (they are practically the same)
 * Fix typo/bad-copy-paste-job in _export.h file

This should hopefully fix the windows build as well.


This addresses bug 308763.
    http://bugs.kde.org/show_bug.cgi?id=308763


Diffs (updated)
-----

  akonadi/socialutils/libakonadisocialutils_export.h 106fbdc 
  akonadi/socialutils/serializer/akonadi_serializer_socialfeeditem.cpp a153d92 
  akonadi/socialutils/socialfeeditem.h 2cbabe9 
  akonadi/socialutils/socialfeeditem.cpp 6d6572b 
  akonadi/socialutils/socialfeeditem_p.h PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/107235/diff/


Testing
-------

Tested with facebook resource, all compiles and works.


Thanks,

Martin Klapetek

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/