[Kde-pim] Proposal for review: Fix ignoring "warn before sending unsigned / unencrypted messages"

[laurent Montel]

Commited in 4.10 (new i18n so we can't backport to 4.9.4)

Thanks for reporting bug.
Regards.

Le mercredi 7 novembre 2012 13:23:58 Christof Arnosti a écrit :
> Hi,
> 
> Thank you for your answer. In the meantime I managed to check out and build 
> the master branch. I also added the proposal to git.reviewboard.kde.org 
> (https://git.reviewboard.kde.org/r/107240/).
> 
> I hope that I didn't override any of your already done work.
> 
> Regards,
> Christof
> 
> Am Dienstag, 6. November 2012, 09.55:07 schrieb laurent Montel:
> > Hi,
> > 
> > I looked at and it's right it's not implemented in kmail2
> > I will read kmail1 code to understand how it worked and adapt your patch.
> > 
> > Le lundi 5 novembre 2012 18:26:23 Christof Arnosti a écrit :
> > > Hi together,
> > > 
> > > This is my first submission to an open source project, so please be gently
> > > :)
> > > 
> > > After I filed a bug under
> > > https://bugs.launchpad.net/ubuntu/+source/kdepim/+bug/1075130 concerning
> > > that "warn before sending unsigned messages" and "warn before sending
> > > unencrypted messages" in the security settings were ignored, I felt like
> > > I could just fix it myself.
> > 
> > Better to report bug to bugs.kde.org, I don't read ubuntu bugs report.
> > 
> > > Since I did not manage to successfully compile the git-trunk, I used the
> > > release 4.9.2 which is shipped with kubuntu 12.10. Since all the changes
> > > are made inside of one function, I hope that there are very little to no
> > > changes necessary to make the fix running on the trunk.
> > > 
> > > I hope that this fix will help to improve kdepim / kmail. For me
> > > personally
> > > kdepim is one of the best solutions, but without this fix it's not
> > > suitable for my personal utilisation.
> > > 
> > > If I did something wrong / could do better the next time I submit a fix (I
> > > don't know formalities in the OSS world very well), please let me know.
> > 
> > Better to use "git.reviewboard.kde.org" for it. It's more easy to comment
> > diff etc.
> > 
> > Regards.
> > 
> > > Best regards
> > > Christof
-- 
Laurent Montel | laurent.montel at kdab.com | KDE/Qt Senior Software Engineer
KDAB (France) S.A.S., a KDAB Group company
Tel. France +33 (0)4 90 84 08 53, Sweden (HQ) +46-563-540090

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/