[Kde-pim] Review Request: folder properties: do not create a job on the stack

[Kevin Krammer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107521/#review22789
-----------------------------------------------------------


Thanks for looking into this.
The orginal code is actually not a problem due to the function never exiting into the event loop, but of course such an assumption is not very safe in the long term.

The best way forward would be to get rid of the exec, i.e. putting everything after exec into a slot and connecting the jobs result signal to it.

- Kevin Krammer


On Nov. 29, 2012, 8 p.m., Jonathan Marten wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107521/
> -----------------------------------------------------------
> 
> (Updated Nov. 29, 2012, 8 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> While reviewing https://git.reviewboard.kde.org/r/107341/, Kevin Krammer observed that a job was being created on the stack (by already existing code).  Since jobs auto-delete themselves by default, this is incorrect and could lead to a crash as a result of a double deletion.
> 
> This change creates the job on the heap instead, allowing it to delete itself when appropriate.
> 
> 
> Diffs
> -----
> 
>   kmail/kmmainwidget.cpp 5568b9a 
> 
> Diff: http://git.reviewboard.kde.org/r/107521/diff/
> 
> 
> Testing
> -------
> 
> Built kdepim with this change, checked operation of "Folder Properties" dialogue for both local and IMAP folders.
> 
> 
> Thanks,
> 
> Jonathan Marten
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/